From: Jeff King <peff@peff.net>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: ls-files --exclude broken?
Date: Wed, 15 Sep 2010 20:16:36 -0400 [thread overview]
Message-ID: <20100916001636.GA2371@sigill.intra.peff.net> (raw)
In-Reply-To: <AANLkTi=L0PA-p5HkWnurfurfyYAQhCBt+Q7SzzCczFLH@mail.gmail.com>
On Wed, Sep 15, 2010 at 07:41:50PM -0400, Jay Soffian wrote:
> On Wed, Sep 15, 2010 at 7:29 PM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
> > I sense another use of negative pathspecs here..
>
> Yeah, I'm really not sure I agree with the reasoning of b5227d8
> (ls-files: excludes should not impact tracked files, 2009-10-12).
>
> I thought about submitting a patch to revert b5227d8, but with an
> additional option to guard the behavior
> (--exclude-cached-files-too-pretty-please).
>
> But I guess I don't see the harm in allowing excludes to apply to
> cached files when it is explicitly requested on the command-line. Here
> I think ls-files is slightly different than the other areas of git
> that don't apply excludes to cached files as it's about, well, listing
> files, and it's clear (I think) what the user wants.
It's not just the command line. It's also what's in .gitignore files. If
you disable just half of that, then you get the awful behavior that some
excludes apply to index files, and some don't.
Yes, it's confusing that "-i" is not actually an inversion for index
files. See
http://article.gmane.org/gmane.comp.version-control.git/131719
It would help if I understood exactly what you're trying to accomplish.
-Peff
next prev parent reply other threads:[~2010-09-16 0:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 22:40 ls-files --exclude broken? Jay Soffian
2010-09-15 23:06 ` Nguyen Thai Ngoc Duy
2010-09-15 23:12 ` Junio C Hamano
2010-09-15 23:19 ` Jay Soffian
2010-09-15 23:29 ` Nguyen Thai Ngoc Duy
2010-09-15 23:41 ` Jay Soffian
2010-09-15 23:47 ` Jay Soffian
2010-09-16 0:16 ` Jeff King [this message]
2010-09-16 0:33 ` Jay Soffian
2010-09-16 0:50 ` Jeff King
2010-09-15 23:34 ` Elijah Newren
2010-09-15 23:21 ` Kevin Ballard
2010-09-15 23:31 ` Daniel Johnson
2010-09-15 23:56 ` [PATCH] git-ls-files.txt: clarify -x/--exclude option Jay Soffian
2010-09-16 0:19 ` Jeff King
2010-09-16 0:41 ` Junio C Hamano
2010-09-16 0:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916001636.GA2371@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).