From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: ls-files --exclude broken? Date: Wed, 15 Sep 2010 20:16:36 -0400 Message-ID: <20100916001636.GA2371@sigill.intra.peff.net> References: <7v62y661pl.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Nguyen Thai Ngoc Duy , Junio C Hamano , git To: Jay Soffian X-From: git-owner@vger.kernel.org Thu Sep 16 02:16:22 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ow29F-0006GF-Nl for gcvg-git-2@lo.gmane.org; Thu, 16 Sep 2010 02:16:22 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753080Ab0IPAQF (ORCPT ); Wed, 15 Sep 2010 20:16:05 -0400 Received: from xen6.gtisc.gatech.edu ([143.215.130.70]:53642 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294Ab0IPAQE (ORCPT ); Wed, 15 Sep 2010 20:16:04 -0400 Received: (qmail 25011 invoked by uid 111); 16 Sep 2010 00:16:02 -0000 Received: from 99-108-226-0.lightspeed.iplsin.sbcglobal.net (HELO sigill.intra.peff.net) (99.108.226.0) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.40) with ESMTPA; Thu, 16 Sep 2010 00:16:02 +0000 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 15 Sep 2010 20:16:36 -0400 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Sep 15, 2010 at 07:41:50PM -0400, Jay Soffian wrote: > On Wed, Sep 15, 2010 at 7:29 PM, Nguyen Thai Ngoc Duy wrote: > > I sense another use of negative pathspecs here.. > > Yeah, I'm really not sure I agree with the reasoning of b5227d8 > (ls-files: excludes should not impact tracked files, 2009-10-12). > > I thought about submitting a patch to revert b5227d8, but with an > additional option to guard the behavior > (--exclude-cached-files-too-pretty-please). > > But I guess I don't see the harm in allowing excludes to apply to > cached files when it is explicitly requested on the command-line. Here > I think ls-files is slightly different than the other areas of git > that don't apply excludes to cached files as it's about, well, listing > files, and it's clear (I think) what the user wants. It's not just the command line. It's also what's in .gitignore files. If you disable just half of that, then you get the awful behavior that some excludes apply to index files, and some don't. Yes, it's confusing that "-i" is not actually an inversion for index files. See http://article.gmane.org/gmane.comp.version-control.git/131719 It would help if I understood exactly what you're trying to accomplish. -Peff