From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Kirill Smelkov" <kirr@landau.phys.spbu.ru>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Axel Bonnet" <axel.bonnet@ensimag.imag.fr>,
"Clément Poulain" <clement.poulain@ensimag.imag.fr>,
"Diane Gasselin" <diane.gasselin@ensimag.imag.fr>
Subject: Re: [PATCH v2 2/3] blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinks
Date: Tue, 21 Sep 2010 16:43:12 -0400 [thread overview]
Message-ID: <20100921204312.GC395@sigill.intra.peff.net> (raw)
In-Reply-To: <vpqzkvaetq4.fsf@bauges.imag.fr>
On Tue, Sep 21, 2010 at 10:18:11PM +0200, Matthieu Moy wrote:
> > This note clearly says "git diff is not affected, that's why we don't
> > write new tests for it".
>
> I disagree with the implication. Git diff is not affected because it
> was done right, but behaving correctly doesn't mean you don't need
> tests. Checking the behavior of diff with tests wouldn't harm (but
> that's not serious not to do it).
Actually, there is some breakage in "git diff" with userdiffs, just not
for textconv (but the fix covers both, so the problem is sort of a
superset). I'm about to send a patch that has some tests, so don't
worry about them for this series.
-Peff
next prev parent reply other threads:[~2010-09-21 20:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 20:39 [BUG, PATCH v2 0/3] Fix {blame,cat-file} --textconv for cases with symlinks Kirill Smelkov
2010-09-20 20:39 ` [PATCH v2 1/3] tests: Prepare --textconv tests for correctly-failing conversion program Kirill Smelkov
2010-09-20 20:39 ` [PATCH v2 2/3] blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinks Kirill Smelkov
2010-09-20 21:13 ` Matthieu Moy
2010-09-21 18:39 ` Kirill Smelkov
2010-09-21 20:18 ` Matthieu Moy
2010-09-21 20:43 ` Jeff King [this message]
2010-09-24 18:20 ` Kirill Smelkov
2010-09-20 20:39 ` [PATCH v2 3/3] blame,cat-file --textconv: Don't assume mode is ``S_IFREF | 0664'' Kirill Smelkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921204312.GC395@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=axel.bonnet@ensimag.imag.fr \
--cc=clement.poulain@ensimag.imag.fr \
--cc=diane.gasselin@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kirr@landau.phys.spbu.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).