From: Clemens Buchacher <drizzd@aon.at>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3 v2] use cache for function names in hunk headers
Date: Sun, 26 Sep 2010 22:43:18 +0200 [thread overview]
Message-ID: <20100926204318.GA19588@localhost> (raw)
In-Reply-To: <4C9F7450.9060208@lsrfire.ath.cx>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Sun, Sep 26, 2010 at 06:26:56PM +0200, René Scharfe wrote:
>
> Is xf needed? Does xdl_emit_diff() handle multiple files in one go?
Right now it does not.
> If you inline xdl_find_func() the struct isn't needed anymore.
[...]
>
> How about something like this?
Yes, that's better. Thanks.
> - /*
> - * Be quite stupid about this for now. Find a line in the old file
> - * before the start of the hunk (and context) which starts with a
> - * plausible character.
> - */
>
> It also removes an outdated comment.
Actually, in the default case, the comment is still correct and
helpful IMO.
> The inlining part should probably split out in its own patch..
I am not sure what you mean here. Do you want to add the parameter
funclineprev to the function and remove the function in the next
page, or do you want to refactor the below into an inline function?
Clemens
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2010-09-26 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 9:59 Patch id tests and diff performance optimization Clemens Buchacher
2010-09-19 9:59 ` [PATCH 1/3] add rebase patch id tests Clemens Buchacher
2010-09-19 9:59 ` [PATCH 2/3] do not search functions for patch ID Clemens Buchacher
2010-09-19 9:59 ` [PATCH 3/3] use cache for function names in hunk headers Clemens Buchacher
2010-09-19 20:24 ` Sverre Rabbelier
2010-09-20 17:36 ` Clemens Buchacher
2010-09-20 19:15 ` Sverre Rabbelier
2010-09-23 7:04 ` [PATCH 3/3 v2] " Clemens Buchacher
2010-09-26 16:26 ` René Scharfe
2010-09-26 20:43 ` Clemens Buchacher [this message]
2010-09-26 22:17 ` René Scharfe
2010-09-27 17:52 ` Junio C Hamano
2010-09-30 18:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926204318.GA19588@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).