From: Jonathan Nieder <jrnieder@gmail.com>
To: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Add bidirectional_transfer_loop()
Date: Thu, 30 Sep 2010 08:55:02 -0500 [thread overview]
Message-ID: <20100930135502.GG4850@burratino> (raw)
In-Reply-To: <1285847579-21954-2-git-send-email-ilari.liusvaara@elisanet.fi>
Ilari Liusvaara wrote:
> --- a/transport-helper.c
> +++ b/transport-helper.c
[...]
> + if (!in_hup && inbufuse < BUFFERSIZE) {
> + stdin_index = nextindex++;
> + polls[stdin_index].fd = 0;
> + transfer_debug("Adding stdin to fds to wait for");
Why not:
trace_printf("trace: adding stdin to ...");
? That would give the user control of where tracing output goes
(settings like GIT_TRACE=17).
If trace is too noisy (I don't think it is), maybe we should
make it more nuanced, like GIT_TRACE=17:transport?
next prev parent reply other threads:[~2010-09-30 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 11:52 [PATCH v2 0/3] git-remote-fd & git-remote-ext Ilari Liusvaara
2010-09-30 11:52 ` [PATCH v2 1/3] Add bidirectional_transfer_loop() Ilari Liusvaara
2010-09-30 13:55 ` Jonathan Nieder [this message]
2010-09-30 15:51 ` Ilari Liusvaara
2010-09-30 15:51 ` Jonathan Nieder
2010-09-30 11:52 ` [PATCH v2 2/3] git-remote-fd Ilari Liusvaara
2010-09-30 12:04 ` Ævar Arnfjörð Bjarmason
2010-09-30 13:14 ` Jonathan Nieder
2010-09-30 13:44 ` Ilari Liusvaara
2010-09-30 11:52 ` [PATCH v2 3/3] git-remote-ext Ilari Liusvaara
2010-09-30 13:45 ` Jonathan Nieder
2010-09-30 20:03 ` Junio C Hamano
2010-10-01 0:30 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930135502.GG4850@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).