From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>, git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] git-remote-ext
Date: Thu, 30 Sep 2010 19:30:22 -0500 [thread overview]
Message-ID: <20101001003022.GA16234@burratino> (raw)
In-Reply-To: <7vfwwrhud1.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Is it just me who finds the placeholders with backslashes somewhat out of
> place where most other placeholders in git are per-cent prefixed?
"\ " and "\\" seemed sane to me but the other ones left me more
puzzled.
It would be nicer when reading the code if it used strbuf_expand(),
too.
prev parent reply other threads:[~2010-10-01 0:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 11:52 [PATCH v2 0/3] git-remote-fd & git-remote-ext Ilari Liusvaara
2010-09-30 11:52 ` [PATCH v2 1/3] Add bidirectional_transfer_loop() Ilari Liusvaara
2010-09-30 13:55 ` Jonathan Nieder
2010-09-30 15:51 ` Ilari Liusvaara
2010-09-30 15:51 ` Jonathan Nieder
2010-09-30 11:52 ` [PATCH v2 2/3] git-remote-fd Ilari Liusvaara
2010-09-30 12:04 ` Ævar Arnfjörð Bjarmason
2010-09-30 13:14 ` Jonathan Nieder
2010-09-30 13:44 ` Ilari Liusvaara
2010-09-30 11:52 ` [PATCH v2 3/3] git-remote-ext Ilari Liusvaara
2010-09-30 13:45 ` Jonathan Nieder
2010-09-30 20:03 ` Junio C Hamano
2010-10-01 0:30 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001003022.GA16234@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).