git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: State of ab/send-email-perl in next
Date: Fri, 1 Oct 2010 21:42:16 +0530	[thread overview]
Message-ID: <20101001161213.GA26521@kytes> (raw)

Hi Junio,

I just pulled in some updates from `next` and I noticed this. Thought
I should let you know incase you miss it: many of the commit messages
are malformed like this one. Notice how Ævar's s-o-b and Avery's
"Reviewed-by:" appear on the same line.

commit 529dd386dda6c6e6d0dad801785d2d943756fb3f
Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date:   Thu Sep 30 13:43:08 2010 +0000

    send-email: make_message_id use "require" instead of "use"
    
    Change the use of Sys::Hostname from a "use" to a "require". The
    former happens in an implicit BEGIN block and is thus immune from the
    if block it's contained in, so it's always loaded.
    
    This should speed up the invocation of git-send-email by a few
    milliseconds.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com>
    Reviewed-by: Jeff King <peff@peff.net>
    >
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

             reply	other threads:[~2010-10-01 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-01 16:12 Ramkumar Ramachandra [this message]
2010-10-01 19:07 ` State of ab/send-email-perl in next Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101001161213.GA26521@kytes \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).