From: Jonathan Nieder <jrnieder@gmail.com>
To: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v4 2/3] git-remote-fd
Date: Mon, 4 Oct 2010 06:25:56 -0500 [thread overview]
Message-ID: <20101004112556.GD4738@burratino> (raw)
In-Reply-To: <1286190258-12724-3-git-send-email-ilari.liusvaara@elisanet.fi>
Ilari Liusvaara wrote:
> --- /dev/null
> +++ b/Documentation/git-remote-fd.txt
Much clearer. The synopsis still does not make me happy; the synopsis
I suggested did not make me happy, either. Some section headers still
have trailing colons but I'm not convinced that's worth the overhead
to fix.
> --- /dev/null
> +++ b/builtin/remote-fd.c
Looks good. Probably input_fd and output_fd should be static ---
Junio, can you fix that up? And now that the documentation makes it
clear this is only for fetch, push, and archive, I guess I am not so
worried about the interface any more.
next prev parent reply other threads:[~2010-10-04 11:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 11:04 [PATCH v4 0/3] git-remote-fd & git-remote-ext Ilari Liusvaara
2010-10-04 11:04 ` [PATCH v4 1/3] Add bidirectional_transfer_loop() Ilari Liusvaara
2010-10-04 11:19 ` Jonathan Nieder
2010-10-04 11:04 ` [PATCH v4 2/3] git-remote-fd Ilari Liusvaara
2010-10-04 11:25 ` Jonathan Nieder [this message]
2010-10-07 5:55 ` Junio C Hamano
2010-10-04 11:04 ` [PATCH v4 3/3] git-remote-ext Ilari Liusvaara
2010-10-04 16:56 ` Sverre Rabbelier
2010-10-04 18:11 ` Ilari Liusvaara
2010-10-04 18:09 ` Sverre Rabbelier
2010-10-04 11:30 ` [PATCH v4 0/3] git-remote-fd & git-remote-ext Jonathan Nieder
2010-10-04 12:06 ` Ilari Liusvaara
2010-10-04 12:28 ` yj2133011
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004112556.GD4738@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox