From: Jonathan Nieder <jrnieder@gmail.com>
To: Shawn Pearce <spearce@spearce.org>
Cc: weigelt@metux.de, git@vger.kernel.org
Subject: Re: large files and low memory
Date: Mon, 4 Oct 2010 14:16:57 -0500 [thread overview]
Message-ID: <20101004191657.GC6466@burratino> (raw)
In-Reply-To: <AANLkTin-mbzt93DWtp71vYBEUcDLHgo=G-6zynT5NC_r@mail.gmail.com>
Shawn Pearce wrote:
> This change only removes the deflate copy. But due to the SHA-1
> consistency issue I alluded to earlier, I think we're still making a
> full copy of the file in memory before we SHA-1 it or deflate it.
Hmm, I _think_ we still use mmap for that (which is why 748af44c needs
to compare the sha1 before and after).
But
1) a one-pass calculation would presumably be a little (5%?) faster
2) if there are smudge/clean filters or autocrlf involved, the
cleaned-up file is backed by swap and this all becomes moot.
next prev parent reply other threads:[~2010-10-04 19:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 9:20 large files and low memory Enrico Weigelt
2010-10-04 18:05 ` Shawn Pearce
2010-10-04 18:24 ` Joshua Jensen
2010-10-04 18:57 ` Shawn Pearce
2010-10-05 0:59 ` Enrico Weigelt
2010-10-05 7:41 ` Enrico Weigelt
2010-10-05 8:01 ` Matthieu Moy
2010-10-05 8:17 ` Enrico Weigelt
2010-10-05 11:29 ` Alex Riesen
2010-10-05 11:38 ` Matthieu Moy
2010-10-05 11:55 ` Nguyen Thai Ngoc Duy
2010-10-05 16:42 ` Junio C Hamano
2010-10-05 10:13 ` Nguyen Thai Ngoc Duy
2010-10-05 19:12 ` Nicolas Pitre
2010-10-04 18:58 ` Jonathan Nieder
2010-10-04 19:11 ` Shawn Pearce
2010-10-04 19:16 ` Jonathan Nieder [this message]
2010-10-05 10:59 ` Nguyen Thai Ngoc Duy
2010-10-05 20:17 ` Nicolas Pitre
2010-10-05 20:34 ` Jonathan Nieder
2010-10-05 21:11 ` Nicolas Pitre
2010-10-05 0:57 ` Enrico Weigelt
2010-10-05 1:07 ` Ævar Arnfjörð Bjarmason
2010-10-05 1:10 ` Jonathan Nieder
2010-10-05 7:35 ` Enrico Weigelt
2010-10-05 13:47 ` Jonathan Nieder
2010-10-05 0:50 ` Enrico Weigelt
2010-10-05 19:06 ` Nicolas Pitre
2010-10-05 22:51 ` Enrico Weigelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004191657.GC6466@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=weigelt@metux.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).