From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: git@vger.kernel.org, pasky@suse.cz,
martin f krafft <madduck@madduck.net>
Subject: Re: [TopGit PATCH 01/10] cat_file: take -i/-w parameters
Date: Sat, 9 Oct 2010 22:32:19 +0200 [thread overview]
Message-ID: <20101009203219.GN29673@pengutronix.de> (raw)
In-Reply-To: <160b8b0eb6152da98f4fa633ac25c7a25ff32aa4.1286524446.git.bert.wesarg@googlemail.com>
Hi Bert,
On Fri, Oct 08, 2010 at 09:57:59AM +0200, Bert Wesarg wrote:
> This changes the way how cat_file selects the source of the file. It
> accepts an optional parameter which is either -i or -w and will react on this
> instead of the branch name. tg-patch is updated accordingly and can now
> accepts the current branch name as argument with -i or -w given.
>
> cat_file was also broken for the worktree case when we are not in the top level.
>
> Also, tg-patch allowed to be on the top-base branch, but -i and -w doesn't
> make sense there too.
>
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
doesn't apply anymore. Do you care to fix and resend? I think it's
your own change to cat_file BTW ... :-)
> ---
>
> I will probably never understand why TopGit accepts to be on a top-base branch.
/me shrugs.
> I will probably never understand why TopGit not changes the cwd to the top level.
I can imagine that strange things can happen then, but I don't have an
example.
> I will probably never understand why TopGit does not use the git-sh-setup.sh.
I'm not sure this works in all cases. And I think it's not sensibe as
we don't have control over this file. And what if it starts providing a
function with the same name as one of our's?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-10-09 20:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 7:57 [TopGit PATCH 01/10] cat_file: take -i/-w parameters Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 02/10] pretty_tree: globalize and respect -i/-w options Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 03/10] branch_empty: use pretty_tree and therefore respect -i/-w Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 04/10] tg-path: use pretty_tree and diff-tree to generate the patch Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 05/10] list_deps: accept -i/-w Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 06/10] tg-summary: " Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 07/10] tg-files: list files changed by the topic branch Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 08/10] tg-prev/tg-next: commands to explore dependencies Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 09/10] [RFC] tg-patch: use ui diff when pager is active Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 10/10] [RFC] tg-patch: simulate mnemonic prefixes Bert Wesarg
2010-10-09 20:46 ` Uwe Kleine-König
2010-10-09 21:03 ` Bert Wesarg
2010-10-09 20:43 ` [TopGit PATCH 09/10] [RFC] tg-patch: use ui diff when pager is active Uwe Kleine-König
2010-10-10 8:04 ` Bert Wesarg
2010-10-09 20:32 ` Uwe Kleine-König [this message]
2010-10-09 20:57 ` [TopGit PATCH 01/10] cat_file: take -i/-w parameters Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009203219.GN29673@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=madduck@madduck.net \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).