From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: git@vger.kernel.org, pasky@suse.cz,
martin f krafft <madduck@madduck.net>
Subject: Re: [TopGit PATCH 09/10] [RFC] tg-patch: use ui diff when pager is active
Date: Sat, 9 Oct 2010 22:43:48 +0200 [thread overview]
Message-ID: <20101009204348.GO29673@pengutronix.de> (raw)
In-Reply-To: <0fd777939e0ca49b6e0013ab667cadbfae55e879.1286524446.git.bert.wesarg@googlemail.com>
Hi Bert,
On Fri, Oct 08, 2010 at 09:58:07AM +0200, Bert Wesarg wrote:
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
can you tell me the motivation for this patch again? It should go into
the commit log, too.
Thanks
Uwe
> ---
> tg-patch.sh | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/tg-patch.sh b/tg-patch.sh
> index 9def6e5..dcce672 100644 tg-patch.sh
> --- a/tg-patch.sh
> +++ b/tg-patch.sh
> @@ -70,7 +70,12 @@ t_tree=$(pretty_tree "$name" $head_from)
> if [ $b_tree = $t_tree ]; then
> echo "No changes."
> else
> - git diff-tree -p --stat $b_tree $t_tree
> + # use the ui diff command when the pager is active
> + diff_command=diff
> + [ "x$GIT_PAGER_IN_USE" = "x1" ] ||
> + diff_command=diff-tree
> +
> + git $diff_command -p --stat $b_tree $t_tree
> fi
>
> echo '-- '
> --
> 1.7.1.1067.g5aeb7
>
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-10-09 20:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 7:57 [TopGit PATCH 01/10] cat_file: take -i/-w parameters Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 02/10] pretty_tree: globalize and respect -i/-w options Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 03/10] branch_empty: use pretty_tree and therefore respect -i/-w Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 04/10] tg-path: use pretty_tree and diff-tree to generate the patch Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 05/10] list_deps: accept -i/-w Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 06/10] tg-summary: " Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 07/10] tg-files: list files changed by the topic branch Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 08/10] tg-prev/tg-next: commands to explore dependencies Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 09/10] [RFC] tg-patch: use ui diff when pager is active Bert Wesarg
2010-10-08 7:58 ` [TopGit PATCH 10/10] [RFC] tg-patch: simulate mnemonic prefixes Bert Wesarg
2010-10-09 20:46 ` Uwe Kleine-König
2010-10-09 21:03 ` Bert Wesarg
2010-10-09 20:43 ` Uwe Kleine-König [this message]
2010-10-10 8:04 ` [TopGit PATCH 09/10] [RFC] tg-patch: use ui diff when pager is active Bert Wesarg
2010-10-09 20:32 ` [TopGit PATCH 01/10] cat_file: take -i/-w parameters Uwe Kleine-König
2010-10-09 20:57 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009204348.GO29673@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=madduck@madduck.net \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).