From: Yann Dirson <ydirson@free.fr>
To: git@vger.kernel.org
Subject: Re: [PATCH v5 3/4] [RFC] Only show bulkmoves in output.
Date: Sun, 10 Oct 2010 14:39:54 +0200 [thread overview]
Message-ID: <20101010123954.GB4983@home.lan> (raw)
In-Reply-To: <1286659895-1813-4-git-send-email-ydirson@altern.org>
On Sat, Oct 09, 2010 at 11:31:34PM +0200, Yann Dirson wrote:
> In theory we could just append those at display time (possibly diluting
> the code too much ?), or before queing the diff. In practice we cannot
> do the latter easily in either case (strcat to a constant string ("./"),
> nor to the paths tighly-allocated from alloc_filespec).
>
> So I went the way of including the trailing "*" from the beginning.
> Since I'm still unsure whether keeping it that way, I leave it as a
> separated patch for now.
Thinking twice, that approach has a major problem: it will break when
a file is named "*". Finally looks like differing this to display
time will be the most sensible solution.
next prev parent reply other threads:[~2010-10-10 12:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 21:31 [PATCH v5 0/4] Detection of directory renames Yann Dirson
2010-10-09 21:31 ` [PATCH v5 1/4] Introduce bulk-move detection in diffcore Yann Dirson
2010-10-09 21:31 ` [PATCH v5 2/4] Add testcases for the --detect-bulk-moves diffcore flag Yann Dirson
2010-10-09 21:31 ` [PATCH v5 3/4] [RFC] Only show bulkmoves in output Yann Dirson
2010-10-09 21:31 ` [PATCH v5 4/4] [RFC] Allow hiding renames of individual files involved in a directory rename Yann Dirson
2010-10-10 12:39 ` Yann Dirson [this message]
2010-10-10 19:59 ` [PATCH 0/2] Re: [PATCH v5 3/4] [RFC] Only show bulkmoves in output Yann Dirson
2010-10-10 19:59 ` [PATCH 1/2] " Yann Dirson
2010-10-10 19:59 ` [PATCH 2/2] [RFC] Transfer special display of toplevel dir to display-time Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101010123954.GB4983@home.lan \
--to=ydirson@free.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).