From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] bash: not all 'git bisect' subcommands make sense when not bisecting
Date: Mon, 11 Oct 2010 00:12:32 +0200 [thread overview]
Message-ID: <20101010221232.GD12529@neumann> (raw)
In-Reply-To: <AANLkTi==oCKgw86fy6sPiPuKuownsbob3xXiY=hHhYrQ@mail.gmail.com>
Hi,
On Mon, Oct 11, 2010 at 12:05:52AM +0200, Sverre Rabbelier wrote:
> Heya,
>
> On Sun, Oct 10, 2010 at 23:39, SZEDER Gábor <szeder@ira.uka.de> wrote:
> > ... but only 'start' and 'replay'. The other commands will either
> > error out or offer to start bisecting for the user.
>
> I'm not sure, following the same concept "git rebase" should not offer
> "--continue" if you're not rebasing.
Actually, my patch follows the same concept of 'git rebase', because
that's exactly what the completion function for 'git rebase' does: it
doesn't offer '--continue' (nor '--abort' and '--skip') if you're not
rebasing.
Best,
Gábor
next prev parent reply other threads:[~2010-10-10 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 21:39 [PATCH 1/2] bash: offer refs for 'git bisect start' SZEDER Gábor
2010-10-10 21:39 ` [PATCH 2/2] bash: not all 'git bisect' subcommands make sense when not bisecting SZEDER Gábor
2010-10-10 22:05 ` Sverre Rabbelier
2010-10-10 22:12 ` SZEDER Gábor [this message]
2010-10-10 22:14 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101010221232.GD12529@neumann \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).