From: Jonathan Nieder <jrnieder@gmail.com>
To: Kris Shannon <kris@shannon.id.au>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Problem with git bundle creation
Date: Fri, 15 Oct 2010 11:52:56 -0500 [thread overview]
Message-ID: <20101015165256.GB10204@burratino> (raw)
In-Reply-To: <AANLkTimsMgsuiS4iT2z_ggD8t0V9xj7ezwxRHk9WgaOw@mail.gmail.com>
Kris Shannon wrote:
> git clone git://github.com/freenet/fred-official.git
> git bundle create bad.gitbundle -1 build01194
> head -2 bad.gitbundle
>
> Problem manifested by a commit message which happens to have a hyphen
> in just the wrong place such that git rev-list --boundary
> --pretty=oneline has a line which exceeds the 1024 buffer limit that
> git bundle is using for reading and happens to read in the rest of the
> commit messsage as a boundary commit.
>
> git bundle should probably be checking that the fgets buffer actually
> ends in a newline and if it doesn't then slurp in more until it does
> (probably discarding it in the process)
Sounds like you've tracked down the problem. Care to write a patch?
(Even a placeholder that die()s would be helpful if you don't have
time for the full proposed fix.)
Thanks for reporting.
Jonathan
prev parent reply other threads:[~2010-10-15 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 1:58 Problem with git bundle creation Kris Shannon
2010-10-15 16:52 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015165256.GB10204@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kris@shannon.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).