Problem with git bundle creation

Problem with git bundle creation

[Kris Shannon]

git clone git://github.com/freenet/fred-official.git
git bundle create bad.gitbundle -1 build01194
head -2 bad.gitbundle

Problem manifested by a commit message which happens to have a hyphen
in just the wrong place such that git rev-list --boundary
--pretty=oneline has a line which exceeds the 1024 buffer limit that
git bundle is using for reading and happens to read in the rest of the
commit messsage as a boundary commit.

git bundle should probably be checking that the fgets buffer actually
ends in a newline and if it doesn't then slurp in more until it does
(probably discarding it in the process)

Re: Problem with git bundle creation

[Jonathan Nieder]

Kris Shannon wrote:

> git clone git://github.com/freenet/fred-official.git
> git bundle create bad.gitbundle -1 build01194
> head -2 bad.gitbundle
> 
> Problem manifested by a commit message which happens to have a hyphen
> in just the wrong place such that git rev-list --boundary
> --pretty=oneline has a line which exceeds the 1024 buffer limit that
> git bundle is using for reading and happens to read in the rest of the
> commit messsage as a boundary commit.
> 
> git bundle should probably be checking that the fgets buffer actually
> ends in a newline and if it doesn't then slurp in more until it does
> (probably discarding it in the process)

Sounds like you've tracked down the problem.  Care to write a patch?
(Even a placeholder that die()s would be helpful if you don't have
time for the full proposed fix.)

Thanks for reporting.
Jonathan