From: Thomas Rast <trast@student.ethz.ch>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Petr Onderka <gsvick@gmail.com>, <git@vger.kernel.org>
Subject: Re: [PATCH] t0003: properly quote $HOME
Date: Sun, 17 Oct 2010 21:34:43 +0200 [thread overview]
Message-ID: <201010172134.43983.trast@student.ethz.ch> (raw)
In-Reply-To: <20101017191827.GD3202@burratino>
Jonathan Nieder wrote:
> Thomas Rast wrote:
>
> > 6df42ab (Add global and system-wide gitattributes, 2010-09-01) forgot
> > to quote one instance of $HOME in the tests. This broke the test for
> > me with the shell complaining about an ambiguous redirect (but only
> > when run with --root for some reason).
>
> Thanks. What shell do you use?
>
> IIRC it is not ambiguous according to POSIX but since e.g. OpenBSD
> complains it is worth fixing.
Oh, huh, so much for the theory that it's --root causing it:
$ sh ./t0003-attributes.sh -q
# passed all 8 test(s)
1..8
$ dash ./t0003-attributes.sh -q
# passed all 8 test(s)
1..8
$ bash ./t0003-attributes.sh -q
not ok - 1 setup
[...]
$ bash --version
GNU bash, version 4.1.7(1)-release (x86_64-suse-linux-gnu)
[...]
Then again, so much for your theory that it's only OpenBSD... ;-)
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-10-17 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 19:13 [PATCH] t0003: properly quote $HOME Thomas Rast
2010-10-17 19:18 ` Jonathan Nieder
2010-10-17 19:34 ` Thomas Rast [this message]
2010-10-18 9:09 ` [PATCH v2] " Thomas Rast
2010-10-18 10:02 ` Jonathan Nieder
2010-10-17 19:37 ` [PATCH] " Matthieu Moy
2010-10-17 21:03 ` Johannes Sixt
2010-10-18 19:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010172134.43983.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gsvick@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).