From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/3] builtins: utilize startup_info->help where possible
Date: Tue, 19 Oct 2010 12:29:53 -0500 [thread overview]
Message-ID: <20101019172953.GC25139@burratino> (raw)
In-Reply-To: <1287495320-27278-2-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
> It helps reduce false alarms while I'm looking for "git foo -h" code
> path that accesses repository.
Not sure I understand. Is the idea that use of startup_info->help
is a marker for "I've checked this code path"?
If that were the only reason, I don't think I'd like the idea.
As it is, I'm a bit conflicted: what if we decide to short-circuit
"git foo --help-all" in the future just like we short-circuit
"git foo -h" now? Would that require a separate flag?
In other words, I'm not sure startup_info->help is a good abstraction.
Maybe (modulo names) it would be better to do
struct startup_info {
...
const char *short_circuit; /* "-h", "--help-all", "--no-index", or NULL */
};
and use
if (!strcmp(startup_info->short_circuit, "-h"))
to allow relaxing the argc == 2 check later?
next prev parent reply other threads:[~2010-10-19 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 13:35 [PATCH 1/3] run_builtin(): save "-h" detection result for later use Nguyễn Thái Ngọc Duy
2010-10-19 13:35 ` [PATCH 2/3] builtins: utilize startup_info->help where possible Nguyễn Thái Ngọc Duy
2010-10-19 17:29 ` Jonathan Nieder [this message]
2010-10-19 18:50 ` Jonathan Nieder
2010-10-19 19:10 ` Junio C Hamano
2010-10-20 1:13 ` Nguyen Thai Ngoc Duy
2010-10-20 1:18 ` Jonathan Nieder
2010-10-19 13:35 ` [PATCH 3/3] builtins: check for startup_info->help, print and exit early Nguyễn Thái Ngọc Duy
2010-10-19 16:33 ` Junio C Hamano
2010-10-20 1:18 ` Nguyen Thai Ngoc Duy
2010-10-19 17:55 ` Jonathan Nieder
2010-10-19 16:48 ` [PATCH 1/3] run_builtin(): save "-h" detection result for later use Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019172953.GC25139@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).