From: Jonathan Nieder <jrnieder@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Jeff King <peff@peff.net>, Dmitry Potapov <dpotapov@gmail.com>,
git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>,
Joey Hess <joey@kitenet.net>
Subject: Re: RFC: [PATCH] ignore SIGINT&QUIT while waiting for external command
Date: Tue, 19 Oct 2010 16:07:53 -0500 [thread overview]
Message-ID: <20101019210753.GB32029@burratino> (raw)
In-Reply-To: <m3fww1lwqw.fsf@localhost.localdomain>
Jakub Narebski wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>> - sigchain_push(SIGINT, SIG_IGN);
>> - sigchain_push(SIGQUIT, SIG_IGN);
>> + if (the_child)
>> + die("What? _Two_ children?");
>> + the_child = cmd;
>> + sigchain_push(SIGINT, interrupted_with_child);
>> + sigchain_push(SIGQUIT, interrupted_with_child);
>
> Please, don't do this. It is almost as bad as error message as
> "You don't exist. Go away".
Hopefully it was clear that the behavior (erroring out) is as
unacceptable as the message.
next prev parent reply other threads:[~2010-10-19 21:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 4:53 git subcommand sigint gotcha Joey Hess
2010-10-19 9:55 ` Dmitry Potapov
2010-10-19 11:59 ` RFC: [PATCH] ignore SIGINT&QUIT while waiting for external command Dmitry Potapov
2010-10-19 13:32 ` Jeff King
2010-10-19 13:40 ` Jeff King
2010-10-19 19:16 ` Jonathan Nieder
2010-10-19 19:50 ` Jeff King
2010-10-19 21:06 ` Jakub Narebski
2010-10-19 21:07 ` Jonathan Nieder [this message]
2010-10-19 16:31 ` Dmitry Potapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019210753.GB32029@burratino \
--to=jrnieder@gmail.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=joey@kitenet.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox