From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] diff: report bogus input to -C/-M/-B
Date: Thu, 21 Oct 2010 11:53:40 -0500 [thread overview]
Message-ID: <20101021165340.GE3732@burratino> (raw)
In-Reply-To: <20101021144947.GA18210@sigill.intra.peff.net>
Jeff King wrote:
> Before:
>
> $ git diff -CM
> $ echo $?
> 128
>
> After:
>
> $ git diff -CM
> error: invalid argument to -C: M
> $ echo $?
> 128
Yes, please.
Who is it that exits(128) in this code path? Are there other
functions it calls that might return an error without reporting it to
stderr?
next prev parent reply other threads:[~2010-10-21 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 14:49 [PATCH] diff: report bogus input to -C/-M/-B Jeff King
2010-10-21 16:53 ` Jonathan Nieder [this message]
2010-10-21 17:07 ` Jeff King
2010-10-21 20:37 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021165340.GE3732@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).