From: Jonathan Nieder <jrnieder@gmail.com>
To: Kevin Ballard <kevin@sb.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] blame: Add option to show author email instead of name
Date: Thu, 21 Oct 2010 13:05:25 -0500 [thread overview]
Message-ID: <20101021180525.GA11501@burratino> (raw)
In-Reply-To: <1287535323-20347-1-git-send-email-kevin@sb.org>
Kevin Ballard wrote:
> +++ b/t/t8002-blame.sh
> @@ -6,4 +6,9 @@ test_description='git blame'
> PROG='git blame -c'
> . "$TEST_DIRECTORY"/annotate-tests.sh
>
> +PROG='git blame -c -e'
> +test_expect_success 'Blame --show-email works' '
> + check_count "<A@test.git>" 1 "<B@test.git>" 1 "<B1@test.git>" 1 "<B2@test.git>" 1 "<author@example.com>" 1 "<C@test.git>" 1 "<D@test.git>" 1
> +'
> +
Bonus nit: does this belong in annotate-tests.sh or does it only apply
to "git blame" and not "git annotate"? If the latter, a note in the
commit message would be helpful.
Thanks for your work.
next prev parent reply other threads:[~2010-10-21 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 6:57 [PATCH] blame: Add option to show author email instead of name Kevin Ballard
2010-10-19 19:02 ` Junio C Hamano
2010-10-20 0:42 ` [PATCH v2] " Kevin Ballard
2010-10-21 18:05 ` Jonathan Nieder [this message]
2010-10-21 20:28 ` Kevin Ballard
2010-10-21 20:32 ` Jonathan Nieder
2010-10-21 20:38 ` Kevin Ballard
2010-10-21 20:49 ` [PATCH v3] " Kevin Ballard
2010-10-21 20:53 ` [PATCH v2] " Jeff King
2010-10-21 20:54 ` Kevin Ballard
2010-10-21 20:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021180525.GA11501@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).