From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Benjamin Kudria <ben@kudria.net>
Subject: Re: [PATCH] fix color.pager = false with "git diff"
Date: Thu, 21 Oct 2010 14:02:58 -0500 [thread overview]
Message-ID: <20101021190258.GA11759@burratino> (raw)
In-Reply-To: <20101021150244.GA18426@sigill.intra.peff.net>
[reordered for convenience]
Jeff King wrote:
> In favor of this patch:
>
> 1. It fixes a real bug.
>
> 2. Perfect is the enemy of the good, and I don't care enough about
> this case to refactor the color code.
>
> Against:
>
> 1. It does nothing to fix other times when this ordering problem may
> arise (I don't think there are others, but I didn't check very
> thoroughly. And of course new ones may appear).
>
> 2. The bug was reported over 2 years ago, and hasn't come up since,
> despite remaining unfixed. Maybe nobody actually cares.
I'd say, go for it. At least one person (Benjamin Kudria, cc-ed) cared
at some point. And including the code means that maybe some future hero
refactoring "git diff" will notice and implement the proper solution.
Though to that end, wouldn't it make sense to include
> A more elegant
> solution would be totally rewriting the color code to check for the
> pager at first output.
in the commit message?
next prev parent reply other threads:[~2010-10-21 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 15:02 [PATCH] fix color.pager = false with "git diff" Jeff King
2010-10-21 19:02 ` Jonathan Nieder [this message]
2010-10-21 22:53 ` Junio C Hamano
2010-10-22 1:49 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021190258.GA11759@burratino \
--to=jrnieder@gmail.com \
--cc=ben@kudria.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).