From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH en/and-cascade-tests 0/7]
Date: Fri, 22 Oct 2010 01:38:37 -0500 [thread overview]
Message-ID: <20101022063837.GA6081@burratino> (raw)
In-Reply-To: <1287544320-8499-4-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
> builtin/branch.c | 3 +++
> builtin/checkout-index.c | 3 +++
> builtin/commit.c | 6 ++++++
> builtin/gc.c | 3 +++
> builtin/ls-files.c | 3 +++
> builtin/merge.c | 3 +++
> builtin/update-index.c | 3 +++
> builtin/upload-archive.c | 7 ++++---
Okay, all of them survive a reroll except upload-archive. As for
upload-archive:
- it already doesn't support "-h"
- it is such low-level plumbing, I don't really mind that. Maybe
someone is using a repository named "-h" (though I hope not, of
course).
Maybe these patches should be squashed. I separated them because they
were easier to write and it would be easier to cc the right people
this way.
The primary motivation for the series is that the repository checker
from the nd/setup series will not be happy without some change like
this. In the git <foo> -h codepath, repository setup is not run so
repository access is forbidden.
The secondary motivation is to create better behavior in situations of
repository corruption. When I type "git checkout -h", I am asking for
a usage message, not a repository self-check. Especially when trying
to repair a repository, commands that do not do what they are asked to
are generally frustrating to use.
Patches apply on top of "test-lib: make test_expect_code a test
command" from the en/and-cascade-tests topic.
Enjoy,
Jonathan
Nguyễn Thái Ngọc Duy (7):
branch -h: show usage even in an invalid repository
checkout-index -h: show usage even in an invalid repository
commit/status -h: show usage even with broken configuration
gc -h: show usage even with broken configuration
ls-files -h: show usage even with corrupt index
merge -h: show usage even with corrupt index
update-index -h: show usage even with corrupt index
builtin/branch.c | 3 +++
builtin/checkout-index.c | 3 +++
builtin/commit.c | 6 ++++++
builtin/gc.c | 3 +++
builtin/ls-files.c | 3 +++
builtin/merge.c | 2 ++
builtin/update-index.c | 3 +++
t/t2006-checkout-index-basic.sh | 24 ++++++++++++++++++++++++
t/t2107-update-index-basic.sh | 32 ++++++++++++++++++++++++++++++++
t/t3004-ls-files-basic.sh | 39 +++++++++++++++++++++++++++++++++++++++
t/t3200-branch.sh | 11 +++++++++++
t/t6500-gc.sh | 28 ++++++++++++++++++++++++++++
t/t7508-status.sh | 24 ++++++++++++++++++++++++
t/t7600-merge.sh | 11 +++++++++++
14 files changed, 192 insertions(+), 0 deletions(-)
create mode 100755 t/t2006-checkout-index-basic.sh
create mode 100755 t/t2107-update-index-basic.sh
create mode 100755 t/t3004-ls-files-basic.sh
create mode 100755 t/t6500-gc.sh
--
1.7.2.3
next prev parent reply other threads:[~2010-10-22 6:42 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 3:11 [PATCH v2 1/4] setup_git_env: print the true $GIT_DIR for debugging Nguyễn Thái Ngọc Duy
2010-10-20 3:11 ` [PATCH v2 2/4] run_builtin(): save "-h" detection result for later use Nguyễn Thái Ngọc Duy
2010-10-21 22:57 ` Junio C Hamano
2010-10-22 1:47 ` Nguyen Thai Ngoc Duy
2010-10-20 3:11 ` [PATCH v2 3/4] builtins: utilize startup_info->help where possible Nguyễn Thái Ngọc Duy
2010-10-20 3:12 ` [PATCH v2 4/4] builtins: check for startup_info->help, print and exit early Nguyễn Thái Ngọc Duy
2010-10-22 6:38 ` Jonathan Nieder [this message]
2010-10-22 6:42 ` [PATCH 1/7] branch -h: show usage even in an invalid repository Jonathan Nieder
2010-10-22 18:30 ` Junio C Hamano
2010-10-24 7:20 ` Jonathan Nieder
2010-10-24 8:13 ` [RFC/PATCH 0/4] update-index: migrate to parse-options API Jonathan Nieder
2010-10-24 8:15 ` [PATCH 1/4] parse-options: allow git commands to invent new option types Jonathan Nieder
2010-10-25 10:31 ` Stephen Boyd
2010-11-29 4:03 ` Jonathan Nieder
2010-10-24 8:15 ` [PATCH 2/4] parse-options: make resuming easier after PARSE_OPT_STOP_AT_NON_OPTION Jonathan Nieder
2010-10-24 8:16 ` [PATCH 3/4] setup: save prefix (original cwd relative to toplevel) in startup_info Jonathan Nieder
2010-10-24 8:18 ` [PATCH 4/4] update-index: migrate to parse-options API Jonathan Nieder
2010-10-25 10:30 ` Stephen Boyd
2010-11-30 2:34 ` Jonathan Nieder
2010-10-24 12:50 ` [RFC/PATCH 0/4] " Nguyen Thai Ngoc Duy
2010-10-27 4:19 ` Junio C Hamano
2010-11-30 2:52 ` [PATCH/RFCv2 0/6] " Jonathan Nieder
2010-11-30 2:55 ` [PATCH 1/6] parse-options: sanity check PARSE_OPT_NOARG flag Jonathan Nieder
2010-11-30 8:13 ` Stephen Boyd
2010-12-01 23:01 ` Junio C Hamano
2010-12-03 7:35 ` Stephen Boyd
2010-12-01 23:36 ` Junio C Hamano
2010-11-30 3:04 ` [PATCH 2/6] parse-options: do not infer PARSE_OPT_NOARG from option type Jonathan Nieder
2010-11-30 8:13 ` Stephen Boyd
2010-11-30 3:08 ` [PATCH 3/6] parse-options: allow git commands to invent new option types Jonathan Nieder
2010-11-30 3:09 ` [PATCH 4/6] parse-options: make resuming easier after PARSE_OPT_STOP_AT_NON_OPTION Jonathan Nieder
2010-11-30 3:10 ` [PATCH 5/6] setup: save prefix (original cwd relative to toplevel) in startup_info Jonathan Nieder
2010-11-30 3:15 ` [PATCH 6/6] update-index: migrate to parse-options API Jonathan Nieder
2010-11-30 8:13 ` Stephen Boyd
2010-11-30 16:00 ` [PATCH] parse-options: always show arghelp when LITERAL_ARGHELP is set Jonathan Nieder
2010-10-22 6:44 ` [PATCH 2/7] checkout-index -h: show usage even in an invalid repository Jonathan Nieder
2010-10-22 6:45 ` [PATCH 3/7] commit/status -h: show usage even with broken configuration Jonathan Nieder
2010-10-22 6:47 ` [PATCH 4/7] gc " Jonathan Nieder
2010-10-22 6:48 ` [PATCH 5/7] ls-files -h: show usage even with corrupt index Jonathan Nieder
2010-10-22 18:30 ` Junio C Hamano
2010-10-22 6:49 ` [PATCH 6/7] merge " Jonathan Nieder
2010-10-22 18:31 ` Junio C Hamano
2010-10-22 6:51 ` [PATCH 7/7] update-index " Jonathan Nieder
2010-10-22 6:55 ` [PATCH en/and-cascade-tests 0/7] avoid repository access during "git <foo> -h" Jonathan Nieder
2010-10-22 11:23 ` [PATCH en/and-cascade-tests 0/7] Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022063837.GA6081@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).