From: Jonathan Nieder <jrnieder@gmail.com>
To: Mathias Lafeldt <misfire@debugon.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] GIT-VERSION-GEN: make use of git describe --dirty
Date: Fri, 22 Oct 2010 10:11:40 -0500 [thread overview]
Message-ID: <20101022151140.GC9224@burratino> (raw)
In-Reply-To: <4CC1745C.70506@debugon.org>
Mathias Lafeldt wrote:
> Currently, GIT-VERSION-GEN invokes the plumbing commands "git update-index" and
> "git diff-index" to determine if the working tree is dirty. It then appends
> "-dirty" to the version string returned by "git describe".
>
> However, as of Git v1.6.6, "git describe" can be told to do all that with the
> "--dirty" option, saving us the plumbing.
This has a minor downside, which is avoiding the nice version numbers when
building Git with git 1.5.6 installed. What is the upside?
next prev parent reply other threads:[~2010-10-22 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1287746107.git.misfire@debugon.org>
2010-10-22 11:24 ` [PATCH 1/3] GIT-VERSION-GEN: make use of git describe --dirty Mathias Lafeldt
2010-10-22 15:11 ` Jonathan Nieder [this message]
2010-10-23 12:23 ` Mathias Lafeldt
2010-10-27 7:50 ` Mathias Lafeldt
2010-10-27 14:28 ` Jakub Narebski
2010-10-22 11:24 ` [PATCH 2/3] GIT-VERSION-GEN: tweak processing of version file Mathias Lafeldt
2010-10-22 11:24 ` [PATCH 3/3] GIT-VERSION-GEN: style nitpicks Mathias Lafeldt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022151140.GC9224@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=misfire@debugon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).