From: Jeff King <peff@peff.net>
To: Kirill Smelkov <kirr@mns.spb.ru>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Axel Bonnet" <axel.bonnet@ensimag.imag.fr>,
"Clément Poulain" <clement.poulain@ensimag.imag.fr>,
"Diane Gasselin" <diane.gasselin@ensimag.imag.fr>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>,
"Kirill Smelkov" <kirr@landau.phys.spbu.ru>,
git@vger.kernel.org
Subject: Re: [BUG, PATCH v5 0/3] Fix {blame,cat-file} --textconv for cases with symlinks
Date: Fri, 22 Oct 2010 16:05:16 -0400 [thread overview]
Message-ID: <20101022200516.GA13926@sigill.intra.peff.net> (raw)
In-Reply-To: <cover.1285758714.git.kirr@mns.spb.ru>
On Wed, Sep 29, 2010 at 03:35:21PM +0400, Kirill Smelkov wrote:
> Kirill Smelkov (3):
> tests: Prepare --textconv tests for correctly-failing conversion
> program
> blame,cat-file: Demonstrate --textconv is wrongly running converter
> on symlinks
> blame,cat-file --textconv: Don't assume mode is ``S_IFREF | 0664''
I finally got around to reviewing this series again (thanks for your
patience, Kirill). This latest version (v5) looks good to me.
-Peff
next prev parent reply other threads:[~2010-10-22 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 11:35 [BUG, PATCH v5 0/3] Fix {blame,cat-file} --textconv for cases with symlinks Kirill Smelkov
2010-09-29 11:35 ` [PATCH v5 1/3] blame,cat-file: Prepare --textconv tests for correctly-failing conversion program Kirill Smelkov
2010-09-29 11:35 ` [PATCH v5 2/3] blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinks Kirill Smelkov
2010-09-29 11:35 ` [PATCH v5 3/3] blame,cat-file --textconv: Don't assume mode is ``S_IFREF | 0664'' Kirill Smelkov
2010-10-22 20:05 ` Jeff King [this message]
2010-10-24 17:40 ` [BUG, PATCH v5 0/3] Fix {blame,cat-file} --textconv for cases with symlinks Kirill Smelkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022200516.GA13926@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=axel.bonnet@ensimag.imag.fr \
--cc=clement.poulain@ensimag.imag.fr \
--cc=diane.gasselin@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kirr@landau.phys.spbu.ru \
--cc=kirr@mns.spb.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).