From: Yann Dirson <ydirson@free.fr>
To: Thiago Farina <tfransosi@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier.
Date: Sat, 23 Oct 2010 20:48:30 +0200 [thread overview]
Message-ID: <20101023184830.GQ4983@home.lan> (raw)
In-Reply-To: <AANLkTikCr5yRHzetY9-T=_rg+PZM-e8ZnQvL79ucws+6@mail.gmail.com>
On Sat, Oct 23, 2010 at 03:11:19PM -0200, Thiago Farina wrote:
> On Sat, Oct 23, 2010 at 12:17 PM, Yann Dirson <ydirson@altern.org> wrote:
> > + - C code is expected to compile when the build is launched with the
> > + following command:
> > +
> > + make CFLAGS="-Wall -Wdeclaration-after-statement -Werror"
>
> Why this is not in the Makefile by default? Also -Wall is already in
> the Makefile.
CFLAGS seems to be used for more than gcc, and -Wall seems to be
portable enough to be overriden only in a couple of cases. It would
not be the same for those flags.
Also note that -Wdeclaration-after-statement is also mentionned in
SubmittingPatches, but I still think it is a better place in
CodingGuidelines, which contributers are most likely to use as a
checklist before publishing.
prev parent reply other threads:[~2010-10-23 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 14:17 [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier Yann Dirson
2010-10-23 17:11 ` Thiago Farina
2010-10-23 18:48 ` Yann Dirson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101023184830.GQ4983@home.lan \
--to=ydirson@free.fr \
--cc=git@vger.kernel.org \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).