* [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier.
@ 2010-10-23 14:17 Yann Dirson
2010-10-23 17:11 ` Thiago Farina
0 siblings, 1 reply; 3+ messages in thread
From: Yann Dirson @ 2010-10-23 14:17 UTC (permalink / raw)
To: git; +Cc: Yann Dirson
It is a bit of a shame to wait for other's review before noticing
decl-after-stmt situations, whereas a quick check could have found it.
There are probably a number of other autoamted checks which could be
described here, but that's a start.
Signed-off-by: Yann Dirson <ydirson@altern.org>
---
Documentation/CodingGuidelines | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 09ffc46..7ecd4f3 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -139,3 +139,8 @@ For C programs:
- When we pass <string, length> pair to functions, we should try to
pass them in that order.
+
+ - C code is expected to compile when the build is launched with the
+ following command:
+
+ make CFLAGS="-Wall -Wdeclaration-after-statement -Werror"
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier.
2010-10-23 14:17 [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier Yann Dirson
@ 2010-10-23 17:11 ` Thiago Farina
2010-10-23 18:48 ` Yann Dirson
0 siblings, 1 reply; 3+ messages in thread
From: Thiago Farina @ 2010-10-23 17:11 UTC (permalink / raw)
To: Yann Dirson; +Cc: git
On Sat, Oct 23, 2010 at 12:17 PM, Yann Dirson <ydirson@altern.org> wrote:
> + - C code is expected to compile when the build is launched with the
> + following command:
> +
> + make CFLAGS="-Wall -Wdeclaration-after-statement -Werror"
Why this is not in the Makefile by default? Also -Wall is already in
the Makefile.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier.
2010-10-23 17:11 ` Thiago Farina
@ 2010-10-23 18:48 ` Yann Dirson
0 siblings, 0 replies; 3+ messages in thread
From: Yann Dirson @ 2010-10-23 18:48 UTC (permalink / raw)
To: Thiago Farina; +Cc: git
On Sat, Oct 23, 2010 at 03:11:19PM -0200, Thiago Farina wrote:
> On Sat, Oct 23, 2010 at 12:17 PM, Yann Dirson <ydirson@altern.org> wrote:
> > + - C code is expected to compile when the build is launched with the
> > + following command:
> > +
> > + make CFLAGS="-Wall -Wdeclaration-after-statement -Werror"
>
> Why this is not in the Makefile by default? Also -Wall is already in
> the Makefile.
CFLAGS seems to be used for more than gcc, and -Wall seems to be
portable enough to be overriden only in a couple of cases. It would
not be the same for those flags.
Also note that -Wdeclaration-after-statement is also mentionned in
SubmittingPatches, but I still think it is a better place in
CodingGuidelines, which contributers are most likely to use as a
checklist before publishing.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-23 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-23 14:17 [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier Yann Dirson
2010-10-23 17:11 ` Thiago Farina
2010-10-23 18:48 ` Yann Dirson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).