From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [WIP PATCH 01/18] rev-parse: add --internal-cwd and --internal-git-dir for tests
Date: Sun, 24 Oct 2010 10:40:05 -0500 [thread overview]
Message-ID: <20101024154005.GB31764@burratino> (raw)
In-Reply-To: <1287922310-14678-2-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
> --internal-cwd is obvious, no way else to expose it for testing.
>
> --internal-git-dir is introduced because --git-dir prepares its output
> suitable for scripting. For tests, it must be exactly what git stores.
Hmm. Forget this is used in tests, would it make sense to do this
with trace_printf, at the end of setup, as in your earlier patch?
I think it might: just like the exec: lines provide context about what
command is being traced, such trace: cwd: lines would make it clearer
what paths that are being output might be referring to.
Returning to the topic of tests, is it possible to get at these
variables using an external command that is run by git? pre-commit
hook, maybe. Testing of other symptoms is also possible, as in
Frédéric's example.
next prev parent reply other threads:[~2010-10-24 15:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 12:11 [WIP PATCH 00/18] setup tests Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 01/18] rev-parse: add --internal-cwd and --internal-git-dir for tests Nguyễn Thái Ngọc Duy
2010-10-24 15:40 ` Jonathan Nieder [this message]
2010-10-25 0:04 ` Nguyen Thai Ngoc Duy
2010-10-25 10:15 ` Jakub Narebski
2010-10-25 10:30 ` Nguyen Thai Ngoc Duy
2010-10-24 12:11 ` [WIP PATCH 02/18] Add t1510 for setup tests Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 03/18] t1510: setup case #0 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 04/18] t1510: setup case #1 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 05/18] t1510: setup case #2 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 06/18] t1510: setup case #3 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 07/18] t1510: setup case #4 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 08/18] t1510: setup case #5 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 09/18] t1510: setup case #6 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 10/18] t1510: setup case #7 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 11/18] t1510: setup case #8 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 12/18] t1510: setup case #9 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 13/18] t1510: setup case #10 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 14/18] t1510: setup case #11 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 15/18] t1510: setup case #12 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 16/18] t1510: setup case #13 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 17/18] t1510: setup case #14 Nguyễn Thái Ngọc Duy
2010-10-24 12:11 ` [WIP PATCH 18/18] t1510: setup case #15 Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101024154005.GB31764@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox