From: Jonathan Nieder <jrnieder@gmail.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] help.c: Pull cmd_version out of this file.
Date: Wed, 27 Oct 2010 11:45:08 -0500 [thread overview]
Message-ID: <20101027164508.GB11069@burratino> (raw)
In-Reply-To: <AANLkTinxG-=EKeNH3--34Ya4w0E=i_bdmJ7iv2em8C+8@mail.gmail.com>
Thiago Farina wrote:
> On Wed, Oct 27, 2010 at 1:18 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> I thought there was some discussion about another binary in
>> /usr/lib/git-core being a bad thing?
>
> I don't recall, why it's a bad thing?
Because those hardlinks for builtins are present for historical reasons
only. They slow down filename lookup by some miniscule amount and tempt
authors of scripts to try the dashed form of commands.
Ah, found it.[1]
| At this point, adding the dashed-form "git-version" to the filesystem is
| going backwards. These files are only to help people who have old scripts
| from pre 1.6.0 days with "PATH=$(git --exec-path):$PATH" with their
| environment.
|
| We should instead try to not adding them (which would probably need tweak
| in the command list generation code in "git help"), as nobody from pre
| 1.6.0 era would have called "git-version" binary.
Hope that helps.
[1] 4a7a62f3:whats-cooking.txt
http://thread.gmane.org/gmane.comp.version-control.git/155073
next prev parent reply other threads:[~2010-10-27 16:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 20:44 [PATCH] help.c: Pull cmd_version out of this file Thiago Farina
2010-08-30 2:38 ` Jonathan Nieder
2010-08-30 2:40 ` Jonathan Nieder
2010-09-01 2:38 ` Thiago Farina
2010-09-01 3:04 ` Nguyen Thai Ngoc Duy
2010-09-01 3:11 ` Thiago Farina
2010-09-01 6:11 ` Junio C Hamano
2010-09-01 6:22 ` Thiago Farina
2010-09-02 1:04 ` Junio C Hamano
2010-09-02 1:16 ` Thiago Farina
2010-09-02 4:35 ` Jonathan Nieder
2010-09-02 16:31 ` Junio C Hamano
2010-10-27 15:12 ` Thiago Farina
2010-10-27 15:18 ` Jonathan Nieder
2010-10-27 16:06 ` Thiago Farina
2010-10-27 16:45 ` Jonathan Nieder [this message]
2010-10-28 2:13 ` Thiago Farina
2010-10-28 3:11 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027164508.GB11069@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).