git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	git@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Minimum git commit abbrev length (Was Re: -tip: origin tree build failure (was: [GIT PULL] ext4 update) for 2.6.37)
Date: Thu, 28 Oct 2010 13:27:25 -0400	[thread overview]
Message-ID: <20101028172725.GA6814@thunk.org> (raw)
In-Reply-To: <20101028171701.GA18368@elte.hu>

On Thu, Oct 28, 2010 at 07:17:01PM +0200, Ingo Molnar wrote:
> > Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > Yes. Except for the kernel the default git commit abbreviation is
> > borderline too short. Seven hex-chars can easily alias with a few
> > more pulls from me: git will not give aliases at the time it gives
> > a shorthand, but a month or two later the abbreviated commit may
> > no longer be unique.
> > 
> > So I suggest using --abbrev=12 or similar.
> 
> ok. A helper script i use does this:
> 
>    git log --pretty=format:"%h: %s" $@
> 
> I have added --abbrev=12. Might make sense to lengthen the %h
> default in upstream Git as well?

Maybe the right thing to do is add a git config option which allows
for a configurable minimum git commit abbreviation length?

      		   	       	      - Ted

       reply	other threads:[~2010-10-28 17:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1PBKT9-0004Uk-Sm@tytso-glaptop>
     [not found] ` <20101028075631.GA7690@elte.hu>
     [not found]   ` <AANLkTi=8SbOZizWpxLg=Bgp7atdgr8MsR6tnRDYr1+eW@mail.gmail.com>
     [not found]     ` <20101028163854.GA15450@elte.hu>
     [not found]       ` <AANLkTin62vAwJxcsrFk6Yn7Q6tzr-D=EmKKwPazuAJ11@mail.gmail.com>
     [not found]         ` <20101028171701.GA18368@elte.hu>
2010-10-28 17:27           ` Ted Ts'o [this message]
2010-10-28 18:28             ` Minimum git commit abbrev length (Was Re: -tip: origin tree build failure (was: [GIT PULL] ext4 update) for 2.6.37) Linus Torvalds
2010-10-28 18:54               ` Linus Torvalds
2010-10-29  0:14                 ` Minimum git commit abbrev length (Was Re: -tip: origin tree build failure Brandon Casey
     [not found]         ` <7veiba9ev2.fsf@alter.siamese.dyndns.org>
2011-03-10 22:37           ` [PATCH] find_unique_abbrev(): honor caller-supplied "len" better Junio C Hamano
2011-03-10 23:07             ` Linus Torvalds
2011-03-11  0:40               ` Junio C Hamano
2011-03-11  1:16                 ` Linus Torvalds
2011-03-11  1:33                   ` Junio C Hamano
2011-03-11  2:21                     ` Linus Torvalds
2011-03-11  3:09                       ` Junio C Hamano
2011-03-11  3:03                     ` Junio C Hamano
2011-03-11  5:22                       ` Jeff King
2011-03-11  5:33                         ` Jeff King
2011-03-11 22:45                       ` Junio C Hamano
2011-03-13 13:30                         ` Namhyung Kim
2011-03-19  1:22                         ` Jay Soffian
2011-03-19 16:24                           ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101028172725.GA6814@thunk.org \
    --to=tytso@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).