From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] diff: support --root --cached combination
Date: Fri, 29 Oct 2010 11:40:51 -0400 [thread overview]
Message-ID: <20101029154051.GA3022@sigill.intra.peff.net> (raw)
In-Reply-To: <1288346087-20263-1-git-send-email-pclouds@gmail.com>
On Fri, Oct 29, 2010 at 04:54:47PM +0700, Nguyễn Thái Ngọc Duy wrote:
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> I have a ritual of doing "git dic" (short for diff --cached) before
> committing and does not want to break it, even on new repos.
>
> Looks like a good thing and no harm to the rest of the world.
Hmm. What's new is old, I suppose. You might want to read the comments
on my very similar patch here:
http://thread.gmane.org/gmane.comp.version-control.git/95935/focus=96187
-Peff
prev parent reply other threads:[~2010-10-29 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 9:54 [PATCH] diff: support --root --cached combination Nguyễn Thái Ngọc Duy
2010-10-29 10:19 ` Jonathan Nieder
2010-10-29 11:00 ` Nguyen Thai Ngoc Duy
2010-10-29 17:06 ` Junio C Hamano
2010-10-30 11:16 ` [PATCH v2] diff: support --cached on unborn branches Nguyễn Thái Ngọc Duy
2010-10-31 3:12 ` Junio C Hamano
2010-10-31 3:24 ` Nguyen Thai Ngoc Duy
2011-02-03 6:23 ` [PATCH] " Nguyễn Thái Ngọc Duy
2010-10-29 15:40 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029154051.GA3022@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).