From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nathan W. Panike" <nathan.panike@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Fix a formatting error in git-merge.txt
Date: Fri, 29 Oct 2010 10:57:43 -0500 [thread overview]
Message-ID: <20101029155743.GA28839@burratino> (raw)
In-Reply-To: <4ccaebae.e91dec0a.1ac5.ffff8876@mx.google.com>
(+cc: Ram, Junio)
Hi,
Nathan W. Panike wrote:
> Signed-off-by: Nathan W. Panike <nathan.panike@gmail.com>
> ---
> Without this patch, the lines below get set in typewriter mode, which
> just looks wrong.
This part belongs above the "---" line, so future generations can
learn the reason for the patch (and thus avoid undoing it when
considering future changes).
> Documentation/git-merge.txt | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
Thanks. The patch proper looks good to me.
Regards,
Jonathan
prev parent reply other threads:[~2010-10-29 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 15:33 [PATCH] Fix a formatting error in git-merge.txt Nathan W. Panike
2010-10-29 15:57 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029155743.GA28839@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nathan.panike@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).