Re: Refactoring git-rebase.sh and git-rebase--interactive.sh

[Christian Couder <chriscool@tuxfamily.org>]

On Tuesday 02 November 2010 13:33:07 Martin von Zweigbergk wrote:
> (Resending as plain text. Sorry about the spam to the guys on the CC list.)
> 
> Hi,
> 
> I have now been using Git for something like 18 months, and I think it's
> about time that I try to contribute.

Great!

> So, after adding some features to git-rebase.sh (which I will send
> separate mails about), I realized I would have to add them to
> git-rebase--interactive.sh as well. Rather than doing that, I would
> prefer to first extract the common parts of these scripts and add the
> features in only one place. Since this is the first time I do anything
> on Git, I will need a lot of advice.
> 
> My main goal is to extract the commonalities in command line parsing and
> interpretation as well as validation (of command line and repository
> state, and running the pre-rebase hook).
> 
> First of all, do you agree that this should be done and is now a good
> time to do it (I'm thinking mostly about conflicts with other ongoing
> efforts)? While at GitTogether, I talked briefly to Thomas Rast about
> doing this, and he mentioned that resurrecting the git sequencer might
> be a better idea. However, I *think* much of what I was thinking about
> doing involves code that is run before the git sequencer is called. I
> wouldn't mind working on the git sequencer afterwards, unless Christian
> Couder or someone else is currently working on it.

Now that GTAC (http://www.gtac.biz) is over, I plan to work on options 
--continue, --abort and --skip for git cherry-pick/revert. After that I hope 
to be able to refactor the code so that in the end common code is used by 
cherry-pick/revert and rebase.

And I agree that what you want to do does not conflict with my plan. On the 
contrary it might help in the end. Go for it!

Thanks,
Christian.