git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Kevin Ballard <kevin@sb.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] submodule: preserve all arguments exactly when recursing
Date: Tue, 2 Nov 2010 23:37:25 -0500	[thread overview]
Message-ID: <20101103043725.GA10311@burratino> (raw)
In-Reply-To: <1288758882-77286-1-git-send-email-kevin@sb.org>

Hi Kevin,

Kevin Ballard wrote:

>            It's also a reasonable model for how to handle this problem
> in other shell commands.

This caught my attention. :)

> +# Emit a quoted version of the all argument suitable for passing to `eval`
> +# $@ = words to quote
> +#
> +# This is intended to be used like the following:
> +#   orig_args="$(quote_words "$@")"
> +#   # do some work that includes calling shift
> +#   eval "set - $orig_args"
> +#   # now $@ has been restored, suitable for passing to another command
> +#
> +# Note that you cannot simply save off $@ into another variable because
> +# the shell gives $@ and $* special handling in parameter expansion
> +#
> +quote_words ()

Have you looked into "git rev-parse --sq-quote"?

Hope that helps,
Jonathan

  parent reply	other threads:[~2010-11-03  4:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03  4:34 [PATCH 1/2] submodule: preserve all arguments exactly when recursing Kevin Ballard
2010-11-03  4:34 ` [PATCH 2/2] submodule: only preserve flags across recursive status/update invocations Kevin Ballard
2010-11-03  4:37 ` Jonathan Nieder [this message]
2010-11-03  4:40   ` [PATCH 1/2] submodule: preserve all arguments exactly when recursing Kevin Ballard
2010-11-03  5:05     ` [PATCHv2 " Kevin Ballard
2010-11-03  5:28       ` Jonathan Nieder
2010-11-03  5:35         ` Kevin Ballard
2010-11-03  5:05     ` [PATCHv2 2/2] submodule: only preserve flags across recursive status/update invocations Kevin Ballard
2010-11-03  5:38       ` Jonathan Nieder
2010-11-03  5:45         ` Kevin Ballard
2010-11-03  6:26         ` [PATCHv3 1/2] submodule: preserve all arguments exactly when recursing Kevin Ballard
2010-11-03  6:26         ` [PATCHv3 2/2] submodule: only preserve flags across recursive status/update invocations Kevin Ballard
2010-11-05 22:38           ` Junio C Hamano
2010-11-03  5:47     ` [PATCH 1/2] submodule: preserve all arguments exactly when recursing Jonathan Nieder
2010-11-03  5:49       ` Kevin Ballard
2010-11-03  5:30 ` Jonathan Nieder
2010-11-03  5:36   ` Kevin Ballard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101103043725.GA10311@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kevin@sb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).