From: Jonathan Nieder <jrnieder@gmail.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Stephen Boyd <bebarino@gmail.com>,
Markus Heidelberg <markus.heidelberg@web.de>,
Nanako Shiraishi <nanako3@lavabit.com>
Subject: Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patches
Date: Fri, 5 Nov 2010 16:41:59 -0500 [thread overview]
Message-ID: <20101105214159.GA4457@burratino> (raw)
In-Reply-To: <20101020004533.b64d446c.ospite@studenti.unina.it>
Hi Antonio,
Antonio Ospite wrote:
> Junio C Hamano <gitster@pobox.com> wrote:
>> You are breaking the && chain here.
>
> Some other tests do that as well, the last line is a command by
> itself not and-chained with the git-send-email invocation. I guess the
> logic behind this is that the test succeeds if the _last_ command
> succeeds. If this is wrong then some other tests are affected too.
Yes, breaking the && chain is never a good thing.
See:
- t/README: "Chain your test assertions"
- v1.5.4~20 (t9001: add missing && operators, 2008-01-21)
- git log --grep=&&
Hope that helps,
Jonathan
next prev parent reply other threads:[~2010-11-05 21:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 9:38 [PATCH] git-send-email.perl: fix In-Reply-To for second and subsequent patches Antonio Ospite
2010-10-14 18:22 ` Jonathan Nieder
2010-10-15 7:56 ` Antonio Ospite
2010-10-19 9:52 ` [PATCH v2] " Antonio Ospite
2010-10-19 18:26 ` Junio C Hamano
2010-10-19 18:45 ` Junio C Hamano
2010-10-19 22:45 ` Antonio Ospite
2010-10-26 13:50 ` Antonio Ospite
2010-11-05 20:59 ` [PATCH v3] git-send-email.perl: make initial In-Reply-To apply only to first email Antonio Ospite
2010-11-05 22:36 ` Matthieu Moy
2010-11-09 21:23 ` Junio C Hamano
2010-11-10 11:45 ` Antonio Ospite
2010-11-10 19:48 ` Junio C Hamano
2010-11-12 14:55 ` [PATCHi v4] " Antonio Ospite
2010-11-12 20:53 ` Junio C Hamano
2010-11-12 21:44 ` Junio C Hamano
2010-11-12 22:51 ` Antonio Ospite
2010-11-05 21:41 ` Jonathan Nieder [this message]
2010-11-08 11:03 ` [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patches Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101105214159.GA4457@burratino \
--to=jrnieder@gmail.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=markus.heidelberg@web.de \
--cc=nanako3@lavabit.com \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).