From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 3/7] add description parameter to OPT__QUIET
Date: Mon, 8 Nov 2010 14:57:52 -0500 [thread overview]
Message-ID: <20101108195752.GA31270@sigill.intra.peff.net> (raw)
In-Reply-To: <20101108195448.GA12660@burratino>
On Mon, Nov 08, 2010 at 01:54:48PM -0600, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > Maybe my "don't repeat yourself" spider sense is over-reacting, but of
> > 12 callsites, 11 of them will continue to use "be quiet".
>
> Maybe something like this would help alleviate the smell.
> [patch with actual per-command descriptions of quiet mode]
Yeah, that is even better.
-Peff
next prev parent reply other threads:[~2010-11-08 19:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 17:53 [PATCH 0/7] add description parameter to standard option macros René Scharfe
2010-11-08 17:58 ` [PATCH 2/7] add description parameter to OPT__DRY_RUN René Scharfe
2010-11-08 18:00 ` [PATCH 3/7] add description parameter to OPT__QUIET René Scharfe
2010-11-08 18:06 ` René Scharfe
2010-11-08 18:18 ` Jeff King
2010-11-08 19:54 ` Jonathan Nieder
2010-11-08 19:57 ` Jeff King [this message]
2010-11-08 21:06 ` René Scharfe
2010-11-08 18:01 ` [PATCH 4/7] add OPT__FORCE René Scharfe
2010-11-08 18:02 ` [PATCH 5/7] archive: improve --verbose description René Scharfe
2010-11-08 18:03 ` [PATCH 6/7] branch: " René Scharfe
2010-11-08 18:04 ` [PATCH 7/7] verify-tag: document --verbose René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108195752.GA31270@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).