git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joey Hess <joey@kitenet.net>
To: git@vger.kernel.org
Subject: is it kosher for pre-commit to change what's staged?
Date: Wed, 10 Nov 2010 13:08:19 -0400	[thread overview]
Message-ID: <20101110170819.GA3031@gnu.kitenet.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

I've noticed that if I make a pre-commit hook change the files that are
staged, those changes are not reflected in the commit message. For
example, if a pre-commit hook git add's somefile, the commit message
won't reflect that. I guess prepare-commit-msg is being run before
pre-commit for some reason?

-- 
see shy jo

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

             reply	other threads:[~2010-11-10 17:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 17:08 Joey Hess [this message]
2010-11-10 19:57 ` is it kosher for pre-commit to change what's staged? Junio C Hamano
2010-11-10 20:06   ` Jonathan Nieder
2010-11-10 20:45     ` Joey Hess
2010-11-10 22:17       ` Dmitry Potapov
2010-11-11 19:26         ` Jan Hudec
2010-11-11 20:46           ` Joey Hess
2010-11-11 22:03             ` Junio C Hamano
2010-11-11 22:06               ` Kevin Ballard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101110170819.GA3031@gnu.kitenet.net \
    --to=joey@kitenet.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).