From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Time::HiRes is in core for Perl 5.8
Date: Thu, 11 Nov 2010 20:01:48 +0100 [thread overview]
Message-ID: <201011112001.50202.jnareb@gmail.com> (raw)
In-Reply-To: <7vwrojhjiz.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > Therefore there is no need to check if it is installed. We can also
> > import gettimeofday and tv_interval.
> >
> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>
>
> I think "... and 'use 5.008' is at the begining of the script already, "
because gitweb requires Perl 5.8, in order to have good Unicode support.
> is missing before that "Therefore". But otherwise it is a reasonable
> thing to do.
>
> Thanks.
Would you amend commit message when applying it, then?
--
Jakub Narebski
Poland
prev parent reply other threads:[~2010-11-11 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 18:27 [PATCH] gitweb: Time::HiRes is in core for Perl 5.8 Jakub Narebski
2010-11-11 17:12 ` Junio C Hamano
2010-11-11 19:01 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011112001.50202.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).