git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv7 00/11] gitweb: remote_heads feature
Date: Thu, 11 Nov 2010 20:29:21 +0100	[thread overview]
Message-ID: <201011112029.22373.jnareb@gmail.com> (raw)
In-Reply-To: <1289478378-15604-1-git-send-email-giuseppe.bilotta@gmail.com>

On Thu, 11 Nov 2010, Giuseppe Bilotta wrote:

> This 7th version of the remote heads feature for gitweb differs from the
> previous mostly my small tune-ups, renames of internal functions, some
> patch reordering and a final addition.
[...]

I like this version very much.

> Giuseppe Bilotta (11):
>   gitweb: use fullname as hash_base in heads link
>   gitweb: introduce remote_heads feature
>   gitweb: git_get_heads_list accepts an optional list of refs
>   gitweb: separate heads and remotes lists
>   gitweb: nagivation menu for tags, heads and remotes
>   gitweb: allow action specialization in page header
>   gitweb: remotes view for a single remote
>   gitweb: refactor repository URL printing
>   gitweb: provide a routine to display (sub)sections
>   gitweb: group remote heads by remote
>   git instaweb: enable remote_heads

With exception of next to last patch, which contains a few of outdated
comments (see my response for this commit), I don't see any problems.

So, for the whole series:

  Acked-by: Jakub Narebski <jnareb@gmail.com>


Thanks for working diligently on this series, Giuseppe!
-- 
Jakub Narebski
Poland

  parent reply	other threads:[~2010-11-11 19:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11 12:26 [PATCHv7 00/11] gitweb: remote_heads feature Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 01/11] gitweb: use fullname as hash_base in heads link Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 02/11] gitweb: introduce remote_heads feature Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 03/11] gitweb: git_get_heads_list accepts an optional list of refs Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 04/11] gitweb: separate heads and remotes lists Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 05/11] gitweb: nagivation menu for tags, heads and remotes Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 06/11] gitweb: allow action specialization in page header Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 07/11] gitweb: remotes view for a single remote Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 08/11] gitweb: refactor repository URL printing Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 09/11] gitweb: provide a routine to display (sub)sections Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 10/11] gitweb: group remote heads by remote Giuseppe Bilotta
2010-11-11 19:25   ` Jakub Narebski
2010-11-12  8:13     ` [PATCHv7bis " Giuseppe Bilotta
2010-11-11 12:26 ` [PATCHv7 11/11] git instaweb: enable remote_heads Giuseppe Bilotta
2010-11-11 19:29 ` Jakub Narebski [this message]
2010-11-12  8:05   ` [PATCHv7 00/11] gitweb: remote_heads feature Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011112029.22373.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=giuseppe.bilotta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).