From: Joey Hess <joey@kitenet.net>
To: git@vger.kernel.org
Subject: Re: is it kosher for pre-commit to change what's staged?
Date: Thu, 11 Nov 2010 16:46:26 -0400 [thread overview]
Message-ID: <20101111204626.GA13937@gnu.kitenet.net> (raw)
In-Reply-To: <20101111192648.GE30870@efreet.light.src>
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
Jan Hudec wrote:
> The problem point is not big files, but whether they can change the file mode
> associated with the entry, since in this case the tree contains a file, but
> index should contain a symlink. Looking at the documentation, there does not
> seem to be a way to do it.
>
> It might be worth adding support for it now we have a use-case.
I suppose that if I were using smudge filters, I'd probably not need to
use symlinks at all. I'll think about it.
It belatedly occured to me that I already had something else modifying
the index in pre-commit, and smudge filters cannot handle its use case.
That is, etckeeper (http://kitenet.net/~joey/code/etckeeper). The
pre-commit script there stores some metadata about files that git
usually doesn't track, by putting it in a dotfile, and stages that
dotfile for commit. Which currently works fine, except for the minor
problem that the user doesn't see the dotfile listed in the commit
message.
--
see shy jo
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2010-11-11 20:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 17:08 is it kosher for pre-commit to change what's staged? Joey Hess
2010-11-10 19:57 ` Junio C Hamano
2010-11-10 20:06 ` Jonathan Nieder
2010-11-10 20:45 ` Joey Hess
2010-11-10 22:17 ` Dmitry Potapov
2010-11-11 19:26 ` Jan Hudec
2010-11-11 20:46 ` Joey Hess [this message]
2010-11-11 22:03 ` Junio C Hamano
2010-11-11 22:06 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111204626.GA13937@gnu.kitenet.net \
--to=joey@kitenet.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).