From: Thomas Rast <trast@student.ethz.ch>
To: Yann Dirson <ydirson@free.fr>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.
Date: Thu, 11 Nov 2010 23:24:57 +0100 [thread overview]
Message-ID: <201011112324.57572.trast@student.ethz.ch> (raw)
In-Reply-To: <20101111114404.GF8911@home.lan>
Yann Dirson wrote:
> On Thu, Nov 11, 2010 at 11:47:04AM +0100, Thomas Rast wrote:
> > Yann Dirson wrote:
> > > Rationale: this is both shorter to spell and consistent with
> > > --find-copies-harder.
> > [...]
> > > -M[<n>]::
> > > ---detect-renames[=<n>]::
> > > +--find-renames[=<n>]::
> >
> > Umm. The reasoning seems ok for me, but the farthest you can go is
> > deprecating the options. Removing them as in
> >
> > > - else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--detect-renames=") ||
> > > - !strcmp(arg, "--detect-renames")) {
> > > + else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--find-renames=") ||
> > > + !strcmp(arg, "--find-renames")) {
> >
> > would break backwards compatibility.
>
> I don't think we care with compatibility here, since those are not
> part of any release.
Ah well. You're right of course, but you could have mentioned that
somewhere :-)
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-11-11 22:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 20:27 [PATCH] rationalize diffcore-rename options and their doc Yann Dirson
2010-11-10 20:27 ` [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C Yann Dirson
2010-11-11 10:47 ` Thomas Rast
2010-11-11 11:44 ` Yann Dirson
2010-11-11 22:24 ` Thomas Rast [this message]
2010-11-12 7:21 ` Yann Dirson
2010-11-12 3:00 ` Kevin Ballard
2010-11-12 3:56 ` Miles Bader
2010-11-12 7:43 ` Yann Dirson
2010-11-29 22:42 ` Junio C Hamano
2010-11-29 22:52 ` Kevin Ballard
2010-11-30 0:37 ` Junio C Hamano
2010-11-30 7:28 ` [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for Yann Dirson
2010-11-29 21:53 ` [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C Yann Dirson
2010-11-29 22:44 ` Junio C Hamano
2010-11-10 20:27 ` [PATCH 2/2] Keep together options controlling the behaviour of diffcore-rename Yann Dirson
2010-11-16 17:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011112324.57572.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=ydirson@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).