From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH 4/4] builtin: use builtin.h for all builtin commands
Date: Sun, 14 Nov 2010 11:47:51 -0600 [thread overview]
Message-ID: <20101114174751.GE26459@burratino> (raw)
In-Reply-To: <1289745857-16704-5-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> This impeded my efforts to gettextize git, since I'd otherwise have to
> add gettext.h to all of these. Using builtin.h is a good idea in any
> case, since it's defining the prototypes for the cmd_* functions that
> these files define.
Yes, I think Junio acked this before, though I can't it in the archive.
Also compare: http://thread.gmane.org/gmane.comp.version-control.git/49523
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -1,4 +1,4 @@
> -#include "cache.h"
> +#include "builtin.h"
> #include "wt-status.h"
> #include "object.h"
> #include "dir.h"
IMHO this deserves a separate mention in the log message. If it is
just to get gettext.h, why not include gettext.h directly?
next prev parent reply other threads:[~2010-11-14 17:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 14:44 [PATCH 0/4] [PULL] ab/i18n-prereqs, prerequisites for ab/i18n Ævar Arnfjörð Bjarmason
2010-11-14 14:44 ` [PATCH 1/4] Makefile: move "Platform specific tweaks" above LIB_{H,OBJS} Ævar Arnfjörð Bjarmason
2010-11-14 17:23 ` Jonathan Nieder
2010-11-14 17:51 ` Ævar Arnfjörð Bjarmason
2010-11-14 18:51 ` Jonathan Nieder
2010-11-15 16:07 ` Junio C Hamano
2010-11-15 16:11 ` Jonathan Nieder
2010-11-15 16:16 ` Ævar Arnfjörð Bjarmason
2010-11-14 19:12 ` Junio C Hamano
2010-11-14 17:53 ` Jonathan Nieder
2010-11-14 19:08 ` Junio C Hamano
2010-11-14 14:44 ` [PATCH 2/4] t7004-tag.sh: re-arrange git tag comment for clarity Ævar Arnfjörð Bjarmason
2010-11-14 17:32 ` Jonathan Nieder
2010-11-14 17:57 ` Ævar Arnfjörð Bjarmason
2010-11-14 14:44 ` [PATCH 3/4] tests: use test_cmp instead of piping to diff(1) Ævar Arnfjörð Bjarmason
2010-11-14 17:41 ` Jonathan Nieder
2010-11-14 14:44 ` [PATCH 4/4] builtin: use builtin.h for all builtin commands Ævar Arnfjörð Bjarmason
2010-11-14 15:01 ` Sverre Rabbelier
2010-11-14 15:11 ` Ævar Arnfjörð Bjarmason
2010-11-14 18:55 ` Junio C Hamano
2010-11-14 17:47 ` Jonathan Nieder [this message]
2010-11-17 19:54 ` Junio C Hamano
2010-11-17 20:08 ` Ævar Arnfjörð Bjarmason
2010-11-17 20:15 ` Jonathan Nieder
2010-11-14 17:50 ` [PATCH 0/4] [PULL] ab/i18n-prereqs, prerequisites for ab/i18n Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114174751.GE26459@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).