From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH 003/160] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1)
Date: Sun, 14 Nov 2010 12:16:05 -0600 [thread overview]
Message-ID: <20101114181605.GI26459@burratino> (raw)
In-Reply-To: <1289747245-23263-3-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> These are the modifications I made to envsubst.c as I turned it into
> sh-i18n--envsubst.c:
>
> * Added our git-compat-util.h header for xrealloc() and friends.
>
> * Removed inclusion of gettext-specific headers.
>
> * Removed most of main() and replaced it with my own. The modified
> version only does option parsing for --variables. That's all it
> needs.
>
> * Modified error() invocations to use our error() instead of
> error(3).
>
> * Replaced the gettext XNMALLOC(n, size) macro with just
> xmalloc(n). Since XNMALLOC() only allocated char's.
>
> * Removed the string_list_destroy function. It's redundant (also in
> the upstream code).
>
> * Replaced the use of stdbool.h (a C99 header) by doing the following
> replacements on the code:
Nit: can this be moved to a subdir? Maybe po or i18n, or even
envsubst. This could make it clearer that the code has an upstream
and should be updated when upstream is.
Jonathan
next prev parent reply other threads:[~2010-11-14 18:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 15:07 [PATCH 000/160] [PULL] ab/i18n rebased on ab/i18n-prereqs Ævar Arnfjörð Bjarmason
2010-11-14 15:07 ` [PATCH 002/160] Makefile: Set NO_GETTEXT=YesPlease on Windows & MinGW Ævar Arnfjörð Bjarmason
2010-11-15 10:35 ` Erik Faye-Lund
2010-11-14 15:07 ` [PATCH 003/160] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1) Ævar Arnfjörð Bjarmason
2010-11-14 18:16 ` Jonathan Nieder [this message]
2010-11-14 19:15 ` Junio C Hamano
2010-11-14 21:25 ` Ævar Arnfjörð Bjarmason
2010-11-14 21:27 ` Jonathan Nieder
2010-11-14 21:42 ` Ævar Arnfjörð Bjarmason
2010-11-14 21:47 ` Jonathan Nieder
2010-11-14 22:26 ` Ævar Arnfjörð Bjarmason
2010-11-16 0:53 ` [PATCH 000/160] [PULL] ab/i18n rebased on ab/i18n-prereqs Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114181605.GI26459@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).