git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>,
	"Shawn O . Pearce" <spearce@spearce.org>,
	git@vger.kernel.org
Subject: Re: [PATCH/RFC/WIP/POC] git-gui: grep prototype
Date: Sun, 14 Nov 2010 15:54:42 -0600	[thread overview]
Message-ID: <20101114215442.GC16413@burratino> (raw)
In-Reply-To: <1289770869-11665-1-git-send-email-bert.wesarg@googlemail.com>

Bert Wesarg wrote:

> There is one feature that the upstream git gui lacks[1]: This grep gui can start
> the git editor on every line by clicking with button 2 in the result area. The
> git editor will than be started with the environment variable FILENAME and
> LINENUMBER set but no argument given. This makes it possible to distinguish
> between normal, blocking edit operation (like git commit) from this
> open-and-forget type of operation.

This sounds like an excellent sort of thing to add to git grep -O, too
(which currently has very limited support for editors' line number
features).  But what will it do with typical non-git-specific setups
like

	VISUAL=vim

or

	EDITOR="gvim --nofork"

?

Do existing editors support LINENUMBER in the environment?

  reply	other threads:[~2010-11-14 21:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 21:41 [PATCH/RFC/WIP/POC] git-gui: grep prototype Bert Wesarg
2010-11-14 21:54 ` Jonathan Nieder [this message]
2010-11-14 22:04   ` Bert Wesarg
2010-11-14 22:09     ` Jonathan Nieder
2010-11-14 22:15       ` Bert Wesarg
2010-11-14 23:48         ` Jonathan Nieder
2010-11-19 12:15           ` Bert Wesarg
2010-11-19 19:49             ` Jonathan Nieder
2010-11-19 20:16               ` Bert Wesarg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101114215442.GC16413@burratino \
    --to=jrnieder@gmail.com \
    --cc=bert.wesarg@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=patthoyts@users.sourceforge.net \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).