From: Yann Dirson <ydirson@free.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Introduce sorted-array binary-search function.
Date: Tue, 16 Nov 2010 23:04:18 +0100 [thread overview]
Message-ID: <20101116220418.GA3187@home.lan> (raw)
In-Reply-To: <7vy68ti3gr.fsf@alter.siamese.dyndns.org>
On Tue, Nov 16, 2010 at 09:27:16AM -0800, Junio C Hamano wrote:
> Yann Dirson <ydirson@altern.org> writes:
>
> > We use a cpp-based template mechanism to declare the array and its
> > management data, as well as a search function, derived from locate_rename_dst()
> > from diffcore-rename.c. Thanks to Jonathan Nieder for this design idea.
>
> Hmmm.... Yet another binary search...
Well, not exactly another, it still generalizes code that was already here.
> Can we generalize the existing ones first before adding any of this in
> (hint: look for "git grep -w -e hi --and -e lo")?
With great pleasure. I have simply missed those, only looking for the
pattern used in diffcore-rename.
Looking at a few ones, that seems just a matter of:
* refreshing my "[RFC] Add a sorted-list API for use-cases that
require to get the element index." from v2 series
* adding support for more than one func, which I already required for
bulk-rename
next prev parent reply other threads:[~2010-11-16 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 22:38 [PATCH v3] generalizing sorted-array handling Yann Dirson
2010-11-08 22:39 ` [PATCH v3 1/3] Introduce sorted-array binary-search function Yann Dirson
2010-11-16 17:27 ` Junio C Hamano
2010-11-16 22:04 ` Yann Dirson [this message]
2010-11-08 22:39 ` [PATCH v3 2/3] Separate sorted-array type declaration from array declaration Yann Dirson
2010-11-08 22:39 ` [PATCH v3 3/3] Convert diffcore-rename's rename_src to the new sorted-array API Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116220418.GA3187@home.lan \
--to=ydirson@free.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).