From: Jakub Narebski <jnareb@gmail.com>
To: Sylvain Rabot <sylvain@abstraction.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] gitweb: remove test when closing file descriptor
Date: Wed, 17 Nov 2010 00:02:47 +0100 [thread overview]
Message-ID: <201011170002.47678.jnareb@gmail.com> (raw)
In-Reply-To: <1292539020.2511.6.camel@kheops>
On Thu, 16 Dec 2010, Sylvain Rabot wrote:
> On Thu, 2010-12-16 at 14:30 -0800, Jakub Narebski wrote:
> > Sylvain Rabot <sylvain@abstraction.fr> writes:
> >
> > > it happens that closing file descriptor fails whereas
> > > the blob is perfectly readable.
> > >
> > > Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
> > > ---
[...]
> > > - close $fd
> > > - or die_error(404, "Reading blob failed");
> > > + close $fd;
[...]
> > In this place we close read end of pipe after at most reading a few
> > bytes (what -T test does), so what might happen is that writer got
> > SIGPIPE and "failed". But we are not interested in this, so we can
> > safely ignore return from 'close'.
> >
> > I think that some from above explanation should make it to commit
> > message.
>
> Thanks for explaining it, I did not have any idea why it was failing.
> Can I use your explanation as commit message ?
Of course.
Though I am not sure if it is really the reason, it looks reasonable.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-12-16 23:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 21:43 [PATCH 0/3] minor gitweb modifications Sylvain Rabot
2010-12-16 21:43 ` [PATCH 1/3] gitweb: add extensions to highlight feature Sylvain Rabot
2010-12-16 22:22 ` Jakub Narebski
2010-12-16 22:33 ` Sylvain Rabot
2010-12-17 11:17 ` Jakub Narebski
2010-12-16 21:43 ` [PATCH 2/3] gitweb: decorate a bit more remotes Sylvain Rabot
2010-12-16 22:23 ` Jakub Narebski
2010-12-20 12:04 ` Drew Northup
2010-12-16 21:43 ` [PATCH 3/3] gitweb: remove test when closing file descriptor Sylvain Rabot
2010-12-16 22:30 ` Jakub Narebski
2010-12-16 22:37 ` Sylvain Rabot
2010-11-16 23:02 ` Jakub Narebski [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-20 19:01 [PATCH 0/3 v2] minor gitweb modifications Sylvain Rabot
2010-12-20 19:01 ` [PATCH 3/3] gitweb: remove test when closing file descriptor Sylvain Rabot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011170002.47678.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=sylvain@abstraction.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).