From: Jonathan Nieder <jrnieder@gmail.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Gabriel Corona <gabriel.corona@enst-bretagne.fr>, git@vger.kernel.org
Subject: Re: [PATCH] Normalise directory names when pushing to some WebDAV servers
Date: Thu, 18 Nov 2010 23:10:47 -0600 [thread overview]
Message-ID: <20101119051047.GA4201@burratino> (raw)
In-Reply-To: <AANLkTikM8mNv+GiVyDWEJxsf0o3FYaaJj+jdYyiuXnov@mail.gmail.com>
Tay Ray Chuan wrote:
> --- a/http-push.c
> +++ b/http-push.c
> @@ -1086,10 +1086,15 @@ static void process_ls_ref(struct remote_ls_ctx *ls)
> static void handle_remote_ls_ctx(struct xml_ctx *ctx, int tag_closed)
> {
> struct remote_ls_ctx *ls = (struct remote_ls_ctx *)ctx->userData;
> + struct strbuf buf = STRBUF_INIT;
>
> if (tag_closed) {
> if (!strcmp(ctx->name, DAV_PROPFIND_RESP) && ls->dentry_name) {
> if (ls->dentry_flags & IS_DIR) {
> + end_url_with_slash(&buf, ls->dentry_name);
> + free(ls->dentry_name);
> + ls->dentry_name = strbuf_detach(&buf, NULL);
> +
> if (ls->flags & PROCESS_DIRS) {
Nit: might make sense to narrow the scope of buf, to avoid tempting
people to reuse or release it.
Thanks,
Jonathan
next prev parent reply other threads:[~2010-11-19 5:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 0:06 [PATCH] Normalise directory names when pushing to some WebDAV servers Gabriel Corona
2010-11-19 4:02 ` Tay Ray Chuan
2010-11-19 5:10 ` Jonathan Nieder [this message]
2010-11-19 12:46 ` [PATCH 0/6] http (dumb): end urls with slash Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 1/6] shift end_url_with_slash() from http.[ch] to url.[ch] Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 2/6] url: add str wrapper for end_url_with_slash() Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 3/6] http-push: Normalise directory names when pushing to some WebDAV servers Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 4/6] http-backend: use end_url_with_slash() Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 5/6] http-push: check path length before using it Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 6/6] http-push: add trailing slash at arg-parse time, instead of later on Tay Ray Chuan
2010-11-19 18:33 ` [PATCH 5/6] http-push: check path length before using it Jonathan Nieder
2010-11-20 4:28 ` Tay Ray Chuan
2010-11-19 19:18 ` [PATCH 0/6] http (dumb): end urls with slash Jonathan Nieder
2010-11-19 22:54 ` Junio C Hamano
2010-11-20 4:32 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119051047.GA4201@burratino \
--to=jrnieder@gmail.com \
--cc=gabriel.corona@enst-bretagne.fr \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).