From: Jeff King <peff@peff.net>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: "Yann Dirson" <ydirson@free.fr>,
git@vger.kernel.org,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Santi Béjar" <santi@agolina.net>
Subject: Re: [RFC] rebase: use @{upstream} if no upstream specified
Date: Fri, 19 Nov 2010 16:15:33 -0500 [thread overview]
Message-ID: <20101119211533.GA18942@sigill.intra.peff.net> (raw)
In-Reply-To: <AANLkTin+3FuuX_pavZQMrbi4qxjTRvM7nHk1PXcFbeiZ@mail.gmail.com>
On Tue, Nov 16, 2010 at 09:29:46PM -0500, Martin von Zweigbergk wrote:
> > What about simply checking if "rev-parse @{u}" succeeds, in which case
> > we can use upstream_name=@{u} ? If it fails, then we can do the work
> > of finding where the config flaw is (and delegate this to a func).
> > That would help keep the nominal code path short.
>
> Will make sure to find out the error only when needed as you suggest.
>
> I thought I would need the ref name to be able to walk the reflog if my
> other propasal would be accepted (see
> http://thread.gmane.org/gmane.comp.version-control.git/161381), but it
> seems to work with @{u} as well. I just adapted the call from 'git pull'
> (git-parse-remote.sh), but I guess I could use 'git rev-parse @{upstream}'
> instead. It does seem more natural to me.
>
> Maybe one of the guys on the CC list can advise?
I'm not quite sure I understand the question, coming into the middle of
the conversation. If you want to know "can I traverse the reflog of the
upstream with @{u}", the answer is yes. We dereference the ref first
(similarly, foo@{u}@{3.days.ago} looks at the upstream branch's reflog).
If you want the refname, you can also use "git rev-parse
--symbolic-full-name @{u}".
Does that help?
-Peff
next prev parent reply other threads:[~2010-11-19 21:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 20:55 [RFC] rebase: use @{upstream} if no upstream specified Martin von Zweigbergk
2010-11-13 9:51 ` Yann Dirson
2010-11-17 2:29 ` Martin von Zweigbergk
2010-11-19 21:15 ` Jeff King [this message]
2010-11-20 0:26 ` Martin von Zweigbergk
2010-11-20 4:10 ` Jeff King
2010-11-20 13:14 ` Martin von Zweigbergk
2010-11-15 22:48 ` Kevin Ballard
2010-11-15 23:06 ` Martin von Zweigbergk
2010-11-15 23:12 ` Jay Soffian
2010-11-15 23:16 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119211533.GA18942@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=martin.von.zweigbergk@gmail.com \
--cc=santi@agolina.net \
--cc=ydirson@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).