From: Thomas Rast <trast@student.ethz.ch>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>,
<git@vger.kernel.org>, Nanako Shiraishi <nanako3@lavabit.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] rebase -i: remove undocumented '--verify' flag
Date: Mon, 22 Nov 2010 14:14:15 +0100 [thread overview]
Message-ID: <201011221414.15982.trast@student.ethz.ch> (raw)
In-Reply-To: <vpqoc9hsemy.fsf@bauges.imag.fr>
Matthieu Moy wrote:
> Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:
>
> > Remove the undocumented and unused '--verify' flag from interactive
> > rebase.
>
> I don't think this change is good. If a command has a --no-whatever
> flag, one expects the --whatever flag to exist too, even if it's a
> no-op.
[...]
> I think a better change would be to add a comment like
>
> --verify)
> # no-op, exists because --no-verify exists too.
Shouldn't that be
OK_TO_SKIP_PRE_REBASE=
instead, so that it undoes the effect of an earlier --no-verify?
> ;;
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-11-22 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 6:48 [PATCH] rebase -i: remove undocumented '--verify' flag Martin von Zweigbergk
2010-11-22 12:53 ` Matthieu Moy
2010-11-22 13:14 ` Thomas Rast [this message]
2010-11-22 13:29 ` Matthieu Moy
2010-11-22 20:21 ` Martin von Zweigbergk
2010-11-23 2:24 ` Kevin Ballard
2010-11-23 14:41 ` Jeff King
2010-11-23 20:08 ` Junio C Hamano
2010-11-23 20:14 ` Junio C Hamano
2010-11-24 1:09 ` Martin von Zweigbergk
2010-11-22 13:49 ` Martin von Zweigbergk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011221414.15982.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=nanako3@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).