From: Jonathan Nieder <jrnieder@gmail.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t/t9001-send-email.sh: fix '&&' chain in some tests
Date: Mon, 22 Nov 2010 11:00:40 -0600 [thread overview]
Message-ID: <20101122170040.GA2084@burratino> (raw)
In-Reply-To: <1290429109-2318-1-git-send-email-ospite@studenti.unina.it>
Hi,
Antonio Ospite wrote:
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -261,10 +262,10 @@ test_expect_success $PREREQ 'Author From: in message body' '
> test_expect_success $PREREQ 'Author From: in message body' '
> clean_fake_sendmail &&
> git send-email \
> --from="Example <nobody@example.com>" \
> --to=nobody@example.com \
> --smtp-server="$(pwd)/fake.sendmail" \
> $patches &&
> - sed "1,/^\$/d" < msgtxt1 > msgbody1
> + sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
> grep "From: A <author@example.com>" msgbody1
> '
[...]
> $patches &&
> - sed "1,/^\$/d" < msgtxt1 > msgbody1
> + sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
[...]
> @@ -300,5 +300,5 @@ test_expect_success $PREREQ 'Invalid In-Reply-To' '
> $patches \
> - 2>errors
> + 2>errors &&
Good.
> @@ -574,7 +574,7 @@ EOF
> "
>
> test_expect_success $PREREQ '--suppress-cc=sob' '
> - git config --unset sendemail.cccmd
> + git config --unset sendemail.cccmd &&
This one needs a test_might_fail in front, since "git config --unset"
would fail if some future change causes the configuration item not to
be set in the first place.
Thanks.
prev parent reply other threads:[~2010-11-22 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 12:31 [PATCH] t/t9001-send-email.sh: fix '&&' chain in some tests Antonio Ospite
2010-11-22 17:00 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122170040.GA2084@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).