From: Jonathan Nieder <jrnieder@gmail.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
SZEDER Gabor <szeder@ira.uka.de>
Subject: Re: [PATCH] bash completion: add basic support for git-reflog
Date: Mon, 22 Nov 2010 11:20:57 -0600 [thread overview]
Message-ID: <20101122172057.GC2084@burratino> (raw)
In-Reply-To: <1290445749-4884-1-git-send-email-rctay89@gmail.com>
Tay Ray Chuan wrote:
> Gábor: hmm, it really seems that reflog is treated as plumbing - no completion
> is done for it.
Probably because it is listed as such in command-list.txt. I guess
the user-facing command for reflog expiration is meant to be "git gc"?
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1632,6 +1631,18 @@ _git_rebase ()
> __gitcomp "$(__git_refs)"
> }
>
> +_git_reflog ()
> +{
> + local subcommands="show delete expire"
People really do seem to use these commands directly, so I'm all for
this.
I wish there were a way to easily point the end user from "git reflog
show" to "git log --walk-reflogs" (to make the list of other accepted
options more obvious) but I can't think of one.
Regards,
Jonathan
prev parent reply other threads:[~2010-11-22 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 17:32 [PATCH] bash completion: add basic support for git-reflog Tay Ray Chuan
2010-11-22 15:24 ` SZEDER Gábor
2010-11-22 15:50 ` Tay Ray Chuan
2010-11-22 17:09 ` Tay Ray Chuan
2010-11-22 17:20 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122172057.GC2084@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).